Fix slimeboots & slimesling #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchej123
commented
Jan 1, 2023
•
mitchej123
commented
- Use vec3 instead of Vector3d which isn't found on the server
- set entity.motionXYZ manually, as setVelocity is ClientOnly
- Close Crash with tinkers construct slime boots GT-New-Horizons-Modpack#11140
* Use vec3 instead of Vector3d which isn't found on the server * set entity.motionXYZ manually, as setVelocity is ClientOnly
|
Warning: 2 uncommitted changes |
Co-authored-by: Jason Mitchell <[email protected]> Co-authored-by: GitHub GTNH Actions <>
querns
reviewed
Jan 1, 2023
| @@ -32,14 +32,15 @@ public class TinkerGadgets { | |||
|
|
|||
| @Handler | |||
| public void preInit(FMLPreInitializationEvent event) { | |||
|
|
|||
| log.info("Pre Init"); | |||
There was a problem hiding this comment.
I liked them. Can make them more witty ;)
minecraft7771
approved these changes
Jan 4, 2023
Can you please add a recipe for slimeboots and slimesling? I was so happy to see such a cool mechanic was backported, but then I discovered there are no recipes for the items. |
you can find then only but if you have an idea for a recipe why not |
DrParadox7
pushed a commit
to DrParadox7/TinkersConstruct
that referenced
this pull request
May 8, 2023
Upstream commits from GTNH * Improve smeltry GUI tooltip * correct amount * add back vanilla handling when dreamcraft not present Spotless Apply update dep file (cherry picked from commit 5433679) Replace some hard-coded tooltips with translatable text (GTNewHorizons#79) * Make some tooltips translatable * Make some tooltips translatable * Ooops. Now fixed * Make Slimesling tooltip translatable * Make Slime Boots tooltips translatable * Make "Creative" word in tooltip translatable It still obfuscated * update bs+sa --------- update bs+sa Fix: Adding Tooltips to Modifier Items (GTNewHorizons#77) * Adding Tooltips to Modifier Items * spotlessApply (GTNewHorizons#78) Co-authored-by: GitHub GTNH Actions <> * Remove unnecessary block --------- update (GTNewHorizons#75) Revert signature changes of public methods that caused crashes (GTNewHorizons#74) * restore previous public method signature to prevent crash * don't register the event if vanilla config * revert signature changes * Restore original calculation logic --------- adding the config options from the tinkered constructor fork (GTNewHorizons#73) * config option for invulnerability of dropped tools and base EntityItem despawn time * config option to drop life canisters on death * Added config option for dagger damage multiplier when thrown, default = 3x * emulate vanilla behavior by default --------- cache some Loader.isModLoaded calls (GTNewHorizons#72) Fix faucets not working, this logic was removed in Alexdoru's refactor (GTNewHorizons#70) * Fix faucets not working, this logic was removed in Alexdoru's refactor * Update dependencies [ci skip] Update buildscript to RetroFuturaGradle exit RenderGameOverlayEvent earlier use the ScaledResolution of the event instead of creating a new one iterate over Map.entrySet() rather than Map.keyset() and use get() on each iteration potential bug ? ItemSTack was used instead of LandmineStack delete unused float[65536] array in SlimeBounceHandler stop calling EnvironmentChecks and remove dead code in EnvironmentChecks keybinds (GTNewHorizons#67) * unbind keybinds by default * spotless Backport: Only break one block when sneaking (GTNewHorizons#65) * only break one block on shift * sportless Signed-off-by: NexusNull <[email protected]> * fixes https://github.com/GTNewHorizons/TinkersConstruct/pull/65/files/41a1ecea30cb0506d068da30c16fc27dcf64550f#r1071818922 Signed-off-by: NexusNull <[email protected]> Signed-off-by: NexusNull <[email protected]> Fix slimeboots & slimesling (GTNewHorizons#63) * Fix slimeboots & slimesling * Use vec3 instead of Vector3d which isn't found on the server * set entity.motionXYZ manually, as setVelocity is ClientOnly * spotlessApply (GTNewHorizons#64) Co-authored-by: Jason Mitchell <[email protected]> Co-authored-by: GitHub GTNH Actions <> actively update drain comparator output (GTNewHorizons#57) Co-Authored-By: Martin Robertz <[email protected]> Co-Authored-By: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-Authored-By: OneEyeMaker <[email protected]> Co-Authored-By: Alex Ponebshek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.