-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve code quality #6843
Milestone
Comments
11 tasks
t-book
added a commit
that referenced
this issue
Jan 26, 2021
* removed use of magic numbers * Revert changes to OpenLayers library files * Global constant style fixes * Revert geonode/static/geonode/js/ol-2.13/lib/deprecated.js Co-authored-by: Matthew Northcott <[email protected]> Co-authored-by: Alessio Fabiani <[email protected]> Co-authored-by: Toni <[email protected]>
t-book
added a commit
that referenced
this issue
Jan 27, 2021
* Removed redundant enumerate uses. * flake8 fixes Co-authored-by: Alessio Fabiani <[email protected]> Co-authored-by: Matthew Northcott <[email protected]> Co-authored-by: Toni <[email protected]>
afabiani
pushed a commit
that referenced
this issue
Jan 28, 2021
* Removed redundant method override * flake8 fix Co-authored-by: Alessio Fabiani <[email protected]> Co-authored-by: Matthew Northcott <[email protected]>
afabiani
pushed a commit
that referenced
this issue
Jan 28, 2021
* Close open file descriptors * Syntax and style fixes * Amend logic errors Co-authored-by: Matthew Northcott <[email protected]> Co-authored-by: Alessio Fabiani <[email protected]>
afabiani
pushed a commit
that referenced
this issue
Jan 28, 2021
…6838) * Generators as parameters * flake8 fix Co-authored-by: Matthew Northcott <[email protected]> Co-authored-by: Alessio Fabiani <[email protected]>
afabiani
pushed a commit
that referenced
this issue
Jan 28, 2021
…6844) * [Fixes #6797] replace encode-decode instances with utility function * [#6797] Fix some spaces * Added test function for surrogate_escape_string/2 * Remove misleading header * flake8 fix Co-authored-by: Matthew Northcott <[email protected]> Co-authored-by: Alessio Fabiani <[email protected]>
afabiani
pushed a commit
that referenced
this issue
Jan 28, 2021
…ate to provide default value (#6845) * Finished replacing for inline conditionals * Fixed undefined center in maps/tests.py * Fixed few missing get's Co-authored-by: Alessio Fabiani <[email protected]>
afabiani
pushed a commit
that referenced
this issue
Feb 10, 2021
* removes use of six library * Remove remaining 'six' occurences * Fix import in render_metrics.py Co-authored-by: Matthew Northcott <[email protected]> Co-authored-by: Alessio Fabiani <[email protected]>
afabiani
pushed a commit
that referenced
this issue
Feb 11, 2021
…size (#6849) * Replaced resizeimage with PIL.Image.resize * Removed redundant python_resize_image library * Replaced Image.resize() with ImageOps.fit() * Fix imports and remove python_resize_image from setup.cfg Co-authored-by: Alessio Fabiani <[email protected]> Co-authored-by: Matthew Northcott <[email protected]>
afabiani
pushed a commit
that referenced
this issue
Feb 11, 2021
* Simplified long conditionals * flake8 fixes Co-authored-by: Matthew Northcott <[email protected]> Co-authored-by: Alessio Fabiani <[email protected]>
afabiani
pushed a commit
that referenced
this issue
Feb 11, 2021
* Split get/post handling * flake8 fixes Co-authored-by: Matthew Northcott <[email protected]> Co-authored-by: Alessio Fabiani <[email protected]>
afabiani
pushed a commit
that referenced
this issue
Mar 18, 2021
… with f-strings (#7096) * [Fixes #6843] Replace concatenated strings, %-strings, and str.format with f-strings * [Fixes #6843] Replace concatenated strings, %-strings, and str.format with f-strings * - Flake8 issues * [Fixes #6843] Replace concatenated strings, %-strings, and str.format with f-strings * [Fixes #6843] Replace concatenated strings, %-strings, and str.format with f-strings (cherry picked from commit 6d8e654) # Conflicts: # pavement.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reserved for Catalyst Academy 2021
We would like to analyse and find potential improvements in code quality throughout the GeoNode codebase. The following improvements have been proposed and should be addressed by this epic:
The text was updated successfully, but these errors were encountered: