Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group managers are assigned Manage permission on adding a group with any permission in share permissions form #9114

Closed
marthamareal opened this issue Apr 15, 2022 · 1 comment
Assignees
Labels
3.3.x 4.0.x API v2 major A high priority issue which might affect a lot of people or large parts of the codebase master

Comments

@marthamareal
Copy link
Contributor

marthamareal commented Apr 15, 2022

Expected Behavior

On sharing a resource,

  1. Default workflow(AUTO PUBLISH):
  • permission set to a group should apply to all group members and managers.
  • promotion and demotion of group members should not affect the shared permission
  • on removing a member from a group should affect their permission to a resource
  1. Other workflows
  • Managers are only assigned permissions relative to a workflow if the group added is an owner's group or a resource group ( group assigned in resource's metadata)

Actual Behavior

On sharing a resource,

  • In default workflow(AUTO PUBLISH), Managers of a group are given Manage permissions regardless of the assigned permission.

Steps to Reproduce the Problem

  1. as an admin, Select a resource and share it with a group with managers, and assign View permission
  2. Refresh the page and click on share. Notice that managers of the group are added with Manage permission
  3. Access the resource as a manager in the /api/v2/{resource_id}, Notice that only view perms are returned and can not perform manage permissions.

Specifications

  • GeoNode version: master
  • Installation method (manual, GeoNode Docker, SPCGeoNode Docker):
  • Platform:
  • Additional details:
@afabiani
Copy link
Member

@marthamareal the second part of the issue sentence is superseded by #9115

@afabiani afabiani added major A high priority issue which might affect a lot of people or large parts of the codebase API v2 3.3.x master 4.0.x labels Apr 15, 2022
giohappy pushed a commit that referenced this issue Apr 19, 2022
…bers should be filtered by owner and resource group metadata only (#9119)

* [Fixes #9106] Implement API for compact permissions

* [CircleCi] Fix tests

* [CircleCi] Fix tests

* [CircleCi] Fix tests

* [CircleCi] Fix tests

* [CircleCi] Fix tests

* [Fixes #9114] Group managers are assigned Manage permission on adding a group with any permission in share permissions form

* [Fixes #9115] Advanced Workflow: permissions assigned to managers/members should be filtered by owner and resource group metadata only

* - Fixes: The "get_all_level_info" forcibly and wrongly writes manages into the "perm_spec"

 - Fixes: The "update_metadata" does not forward information about group and approval status change to the update method

* - Fixes: promotion/demotion consider the owner's group also
github-actions bot pushed a commit that referenced this issue Apr 19, 2022
… a group with any permission in share permissions form (#9118)

* [Fixes #9106] Implement API for compact permissions

* [CircleCi] Fix tests

* [CircleCi] Fix tests

* [CircleCi] Fix tests

* [CircleCi] Fix tests

* [CircleCi] Fix tests

* [Fixes #9114] Group managers are assigned Manage permission on adding a group with any permission in share permissions form
github-actions bot pushed a commit that referenced this issue Apr 19, 2022
…bers should be filtered by owner and resource group metadata only (#9119)

* [Fixes #9106] Implement API for compact permissions

* [CircleCi] Fix tests

* [CircleCi] Fix tests

* [CircleCi] Fix tests

* [CircleCi] Fix tests

* [CircleCi] Fix tests

* [Fixes #9114] Group managers are assigned Manage permission on adding a group with any permission in share permissions form

* [Fixes #9115] Advanced Workflow: permissions assigned to managers/members should be filtered by owner and resource group metadata only

* - Fixes: The "get_all_level_info" forcibly and wrongly writes manages into the "perm_spec"

 - Fixes: The "update_metadata" does not forward information about group and approval status change to the update method

* - Fixes: promotion/demotion consider the owner's group also
giohappy pushed a commit that referenced this issue Apr 19, 2022
…bers should be filtered by owner and resource group metadata only (#9119) (#9159)

* [Fixes #9106] Implement API for compact permissions

* [CircleCi] Fix tests

* [CircleCi] Fix tests

* [CircleCi] Fix tests

* [CircleCi] Fix tests

* [CircleCi] Fix tests

* [Fixes #9114] Group managers are assigned Manage permission on adding a group with any permission in share permissions form

* [Fixes #9115] Advanced Workflow: permissions assigned to managers/members should be filtered by owner and resource group metadata only

* - Fixes: The "get_all_level_info" forcibly and wrongly writes manages into the "perm_spec"

 - Fixes: The "update_metadata" does not forward information about group and approval status change to the update method

* - Fixes: promotion/demotion consider the owner's group also

Co-authored-by: Alessio Fabiani <[email protected]>
giohappy pushed a commit that referenced this issue Apr 19, 2022
… a group with any permission in share permissions form (#9118) (#9158)

* [Fixes #9106] Implement API for compact permissions

* [CircleCi] Fix tests

* [CircleCi] Fix tests

* [CircleCi] Fix tests

* [CircleCi] Fix tests

* [CircleCi] Fix tests

* [Fixes #9114] Group managers are assigned Manage permission on adding a group with any permission in share permissions form

Co-authored-by: Alessio Fabiani <[email protected]>
github-actions bot pushed a commit that referenced this issue Apr 19, 2022
… a group with any permission in share permissions form (#9118)

* [Fixes #9106] Implement API for compact permissions

* [CircleCi] Fix tests

* [CircleCi] Fix tests

* [CircleCi] Fix tests

* [CircleCi] Fix tests

* [CircleCi] Fix tests

* [Fixes #9114] Group managers are assigned Manage permission on adding a group with any permission in share permissions form
afabiani pushed a commit that referenced this issue Apr 19, 2022
… a group with any permission in share permissions form (#9118) (#9164)

* [Fixes #9106] Implement API for compact permissions

* [CircleCi] Fix tests

* [CircleCi] Fix tests

* [CircleCi] Fix tests

* [CircleCi] Fix tests

* [CircleCi] Fix tests

* [Fixes #9114] Group managers are assigned Manage permission on adding a group with any permission in share permissions form

Co-authored-by: Alessio Fabiani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.3.x 4.0.x API v2 major A high priority issue which might affect a lot of people or large parts of the codebase master
Projects
None yet
Development

No branches or pull requests

2 participants