-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fixes #9115] Advanced Workflow: permissions assigned to managers/members should be filtered by owner and resource group metadata only #9119
Conversation
… a group with any permission in share permissions form
…bers should be filtered by owner and resource group metadata only
Codecov Report
@@ Coverage Diff @@
## master #9119 +/- ##
==========================================
- Coverage 60.71% 60.71% -0.01%
==========================================
Files 805 805
Lines 49294 49291 -3
Branches 7589 7591 +2
==========================================
- Hits 29931 29928 -3
+ Misses 17702 17701 -1
- Partials 1661 1662 +1 |
…s into the "perm_spec" - Fixes: The "update_metadata" does not forward information about group and approval status change to the update method
…bers should be filtered by owner and resource group metadata only (#9119) * [Fixes #9106] Implement API for compact permissions * [CircleCi] Fix tests * [CircleCi] Fix tests * [CircleCi] Fix tests * [CircleCi] Fix tests * [CircleCi] Fix tests * [Fixes #9114] Group managers are assigned Manage permission on adding a group with any permission in share permissions form * [Fixes #9115] Advanced Workflow: permissions assigned to managers/members should be filtered by owner and resource group metadata only * - Fixes: The "get_all_level_info" forcibly and wrongly writes manages into the "perm_spec" - Fixes: The "update_metadata" does not forward information about group and approval status change to the update method * - Fixes: promotion/demotion consider the owner's group also
…bers should be filtered by owner and resource group metadata only (#9119) (#9159) * [Fixes #9106] Implement API for compact permissions * [CircleCi] Fix tests * [CircleCi] Fix tests * [CircleCi] Fix tests * [CircleCi] Fix tests * [CircleCi] Fix tests * [Fixes #9114] Group managers are assigned Manage permission on adding a group with any permission in share permissions form * [Fixes #9115] Advanced Workflow: permissions assigned to managers/members should be filtered by owner and resource group metadata only * - Fixes: The "get_all_level_info" forcibly and wrongly writes manages into the "perm_spec" - Fixes: The "update_metadata" does not forward information about group and approval status change to the update method * - Fixes: promotion/demotion consider the owner's group also Co-authored-by: Alessio Fabiani <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-3.3.x 3.3.x
# Navigate to the new working tree
cd .worktrees/backport-3.3.x
# Create a new branch
git switch --create backport-9119-to-3.3.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick fc00c9c615bbd201fb5ea3c026867886d62ef652
# Push it to GitHub
git push --set-upstream origin backport-9119-to-3.3.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-3.3.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-3.3.x 3.3.x
# Navigate to the new working tree
cd .worktrees/backport-3.3.x
# Create a new branch
git switch --create backport-9119-to-3.3.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick fc00c9c615bbd201fb5ea3c026867886d62ef652
# Push it to GitHub
git push --set-upstream origin backport-9119-to-3.3.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-3.3.x Then, create a pull request where the |
References: #9115
Checklist
For all pull requests:
The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):
Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.