Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #9114] Group managers are assigned Manage permission on adding a group with any permission in share permissions form #9118

Merged
merged 9 commits into from
Apr 19, 2022

Conversation

afabiani
Copy link
Member

References: #9114

Note: The second part of this issue is superseded by #9115

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@afabiani afabiani added this to the 4.0.0 milestone Apr 15, 2022
@afabiani afabiani self-assigned this Apr 15, 2022
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Apr 15, 2022
@codecov
Copy link

codecov bot commented Apr 15, 2022

Codecov Report

Merging #9118 (36e7add) into master (a9f7db5) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #9118      +/-   ##
==========================================
- Coverage   60.71%   60.71%   -0.01%     
==========================================
  Files         805      805              
  Lines       49294    49295       +1     
  Branches     7589     7590       +1     
==========================================
  Hits        29931    29931              
  Misses      17702    17702              
- Partials     1661     1662       +1     

@marthamareal
Copy link
Contributor

@afabiani on testing this, I can still replicate the issues

  • Managers of a group(this group is not related to the resource or owner) are given Manage permissions regardless of the assigned permission.
  • promotion, demotion, and removal of members (resource group, and owner group dont affect permissions)
  • When a group is removed from the resource(managers of the removed group still have their mange perms on the re)

@afabiani
Copy link
Member Author

@marthamareal see below

@afabiani on testing this, I can still replicate the issues

  • Managers of a group(this group is not related to the resource or owner) are given Manage permissions regardless of the assigned permission.

This one is fixed by #9119

  • promotion, demotion, and removal of members (resource group, and owner group dont affect permissions)

This is wanted as far as I understood on AUTO_PUBLISHING

  • When a group is removed from the resource(managers of the removed group still have their mange perms on the re)

This is wanted as far as I understood on AUTO_PUBLISHING

@giohappy giohappy merged commit d8d333e into master Apr 19, 2022
github-actions bot pushed a commit that referenced this pull request Apr 19, 2022
… a group with any permission in share permissions form (#9118)

* [Fixes #9106] Implement API for compact permissions

* [CircleCi] Fix tests

* [CircleCi] Fix tests

* [CircleCi] Fix tests

* [CircleCi] Fix tests

* [CircleCi] Fix tests

* [Fixes #9114] Group managers are assigned Manage permission on adding a group with any permission in share permissions form
giohappy pushed a commit that referenced this pull request Apr 19, 2022
… a group with any permission in share permissions form (#9118) (#9158)

* [Fixes #9106] Implement API for compact permissions

* [CircleCi] Fix tests

* [CircleCi] Fix tests

* [CircleCi] Fix tests

* [CircleCi] Fix tests

* [CircleCi] Fix tests

* [Fixes #9114] Group managers are assigned Manage permission on adding a group with any permission in share permissions form

Co-authored-by: Alessio Fabiani <[email protected]>
@afabiani afabiani added the backport 3.3.x PR should be backported to target version label Apr 19, 2022
github-actions bot pushed a commit that referenced this pull request Apr 19, 2022
… a group with any permission in share permissions form (#9118)

* [Fixes #9106] Implement API for compact permissions

* [CircleCi] Fix tests

* [CircleCi] Fix tests

* [CircleCi] Fix tests

* [CircleCi] Fix tests

* [CircleCi] Fix tests

* [Fixes #9114] Group managers are assigned Manage permission on adding a group with any permission in share permissions form
@afabiani afabiani deleted the ISSUE_9114 branch April 19, 2022 19:36
afabiani pushed a commit that referenced this pull request Apr 19, 2022
… a group with any permission in share permissions form (#9118) (#9164)

* [Fixes #9106] Implement API for compact permissions

* [CircleCi] Fix tests

* [CircleCi] Fix tests

* [CircleCi] Fix tests

* [CircleCi] Fix tests

* [CircleCi] Fix tests

* [Fixes #9114] Group managers are assigned Manage permission on adding a group with any permission in share permissions form

Co-authored-by: Alessio Fabiani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 3.3.x PR should be backported to target version cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants