-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fixes #9114] Group managers are assigned Manage permission on adding a group with any permission in share permissions form #9118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a group with any permission in share permissions form
Codecov Report
@@ Coverage Diff @@
## master #9118 +/- ##
==========================================
- Coverage 60.71% 60.71% -0.01%
==========================================
Files 805 805
Lines 49294 49295 +1
Branches 7589 7590 +1
==========================================
Hits 29931 29931
Misses 17702 17702
- Partials 1661 1662 +1 |
@afabiani on testing this, I can still replicate the issues
|
@marthamareal see below
This one is fixed by #9119
This is wanted as far as I understood on
This is wanted as far as I understood on |
github-actions bot
pushed a commit
that referenced
this pull request
Apr 19, 2022
… a group with any permission in share permissions form (#9118) * [Fixes #9106] Implement API for compact permissions * [CircleCi] Fix tests * [CircleCi] Fix tests * [CircleCi] Fix tests * [CircleCi] Fix tests * [CircleCi] Fix tests * [Fixes #9114] Group managers are assigned Manage permission on adding a group with any permission in share permissions form
giohappy
pushed a commit
that referenced
this pull request
Apr 19, 2022
… a group with any permission in share permissions form (#9118) (#9158) * [Fixes #9106] Implement API for compact permissions * [CircleCi] Fix tests * [CircleCi] Fix tests * [CircleCi] Fix tests * [CircleCi] Fix tests * [CircleCi] Fix tests * [Fixes #9114] Group managers are assigned Manage permission on adding a group with any permission in share permissions form Co-authored-by: Alessio Fabiani <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Apr 19, 2022
… a group with any permission in share permissions form (#9118) * [Fixes #9106] Implement API for compact permissions * [CircleCi] Fix tests * [CircleCi] Fix tests * [CircleCi] Fix tests * [CircleCi] Fix tests * [CircleCi] Fix tests * [Fixes #9114] Group managers are assigned Manage permission on adding a group with any permission in share permissions form
afabiani
pushed a commit
that referenced
this pull request
Apr 19, 2022
… a group with any permission in share permissions form (#9118) (#9164) * [Fixes #9106] Implement API for compact permissions * [CircleCi] Fix tests * [CircleCi] Fix tests * [CircleCi] Fix tests * [CircleCi] Fix tests * [CircleCi] Fix tests * [Fixes #9114] Group managers are assigned Manage permission on adding a group with any permission in share permissions form Co-authored-by: Alessio Fabiani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport 3.3.x
PR should be backported to target version
cla-signed
CLA Bot: community license agreement signed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References: #9114
Note: The second part of this issue is superseded by #9115
Checklist
For all pull requests:
The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):
Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.