[Fixes #7761] Harvested resource permissions assignment must follow the same logic as uploaded resources #7760

meomancer · 2021-07-09T03:39:24Z

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

Confirm you have read the contribution guidelines
You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
The issue connected to the PR must have Labels and Milestone assigned
PR for bug fixes and small new features are presented as a single commit
Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
This PR passes the QA checks: flake8 geonode
Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

Merge from upsteram

Bumps [urllib3](https://github.com/urllib3/urllib3) from 1.26.2 to 1.26.3. - [Release notes](https://github.com/urllib3/urllib3/releases) - [Changelog](https://github.com/urllib3/urllib3/blob/1.26.3/CHANGES.rst) - [Commits](urllib3/urllib3@1.26.2...1.26.3) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Toni <[email protected]>

…6881) * [Fixes GeoNode#6880] Circle CI upload tests fail irregulary * CircleCI test fix: sometimes expires due to upload timeout in the test environment * - Avoid infinite loop on upload testing * Revert "CircleCI test fix: sometimes expires due to upload timeout in the test environment" This reverts commit 66139fd. Co-authored-by: Alessio Fabiani <[email protected]> Co-authored-by: afabiani <[email protected]>

…ps (GeoNode#6915)

…de#6911) * get meaningful document filenames on download * - Strip extension from document title before slugify it (e.g.: image.jpg instead of imagejpg.jpg) Co-authored-by: afabiani <[email protected]> Co-authored-by: Alessio Fabiani <[email protected]>

…loop on "wait_for_progress"

…ng slash at the end of GEOSERVER_LOCATION (GeoNode#6913) * [Fixes GeoNode#6916] gsimporter.api.NotFound caused by missing trailing slash at the end of GEOSERVER_LOCATION * [Fixes GeoNode#6916] unit test for GEOSERVER_LOCATION

Bumps [django-cors-headers](https://github.com/adamchainz/django-cors-headers) from 3.6.0 to 3.7.0. - [Release notes](https://github.com/adamchainz/django-cors-headers/releases) - [Changelog](https://github.com/adamchainz/django-cors-headers/blob/master/HISTORY.rst) - [Commits](adamchainz/django-cors-headers@3.6.0...3.7.0) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [amqp](https://github.com/celery/py-amqp) from 5.0.3 to 5.0.5. - [Release notes](https://github.com/celery/py-amqp/releases) - [Changelog](https://github.com/celery/py-amqp/blob/master/Changelog) - [Commits](celery/py-amqp@v5.0.3...v5.0.5) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [pip](https://github.com/pypa/pip) from 21.0 to 21.0.1. - [Release notes](https://github.com/pypa/pip/releases) - [Changelog](https://github.com/pypa/pip/blob/master/NEWS.rst) - [Commits](pypa/pip@21.0...21.0.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [coverage](https://github.com/nedbat/coveragepy) from 5.3.1 to 5.4. - [Release notes](https://github.com/nedbat/coveragepy/releases) - [Changelog](https://github.com/nedbat/coveragepy/blob/master/CHANGES.rst) - [Commits](nedbat/coveragepy@coverage-5.3.1...coverage-5.4) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [pytest](https://github.com/pytest-dev/pytest) from 6.2.1 to 6.2.2. - [Release notes](https://github.com/pytest-dev/pytest/releases) - [Changelog](https://github.com/pytest-dev/pytest/blob/master/CHANGELOG.rst) - [Commits](pytest-dev/pytest@6.2.1...6.2.2) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [djangorestframework-gis](https://github.com/openwisp/django-rest-framework-gis) from 0.16 to 0.17. - [Release notes](https://github.com/openwisp/django-rest-framework-gis/releases) - [Changelog](https://github.com/openwisp/django-rest-framework-gis/blob/master/CHANGES.rst) - [Commits](openwisp/django-rest-framework-gis@v0.16.0...v0.17.0) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

… it has… (GeoNode#6923) * [Fixes GeoNode#6922][REST API v2] Expose the curated thumbnail URL if it has been uploaded * - Add REST APIs test suite to CircleCI

* [Cleanup and Refactor] Remove QGIS server backend dependencies * [Cleanup and Refactor] Remove QGIS server backend dependencies * - Fix LGTM issues

…_auth_middleware Feature#650 basic auth middleware

Upstream master

…olutions_master

cla-bot · 2021-07-09T03:39:26Z

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @meomancer on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

meomancer · 2021-07-09T03:39:36Z

this fix geosolutions-it/nexus-geonode#301
this fix #7761

removeing harvester to handle default permission
CC @ricardogsilva

lgtm-com · 2021-07-09T03:49:35Z

This pull request introduces 1 alert when merging 2577662 into 8e97218 - view on LGTM.com

new alerts:

1 for Unused local variable

lgtm-com · 2021-07-09T09:53:38Z

This pull request introduces 1 alert when merging 2be99c8 into d81d86d - view on LGTM.com

new alerts:

1 for Unused local variable

codecov · 2021-07-09T10:20:35Z

Codecov Report

Merging #7760 (ff589be) into master (3799f82) will decrease coverage by 0.07%.
The diff coverage is 80.00%.

❗ Current head ff589be differs from pull request most recent head 2a59980. Consider uploading reports for the commit 2a59980 to get more accurate results

@@            Coverage Diff             @@
##           master    #7760      +/-   ##
==========================================
- Coverage   56.77%   56.69%   -0.08%     
==========================================
  Files         700      699       -1     
  Lines       43820    43630     -190     
  Branches     5622     5585      -37     
==========================================
- Hits        24877    24738     -139     
+ Misses      17500    17459      -41     
+ Partials     1443     1433      -10

lgtm-com · 2021-07-12T16:39:25Z

This pull request introduces 1 alert when merging 81d5b87 into 4b97410 - view on LGTM.com

new alerts:

1 for Unused local variable

afabiani · 2021-07-13T07:45:13Z

@meomancer please fix PEP8 issues
^@^@geonode/harvesting/harvesters/base.py:157:9: F841 local variable 'harvester' is assigned to but never used

meomancer · 2021-07-19T02:02:15Z

updated @afabiani

ricardogsilva · 2021-07-21T09:22:42Z

@meomancer the PR looks good to me. Please update it with the latest changes from master and then I'll give a final review and approval.

giohappy

fix conflicts

ricardogsilva

I'm +1 for merging this

giohappy and others added 30 commits January 20, 2021 09:37

Merge pull request GeoNode#626 from geosolutions-it/merge_from_upsteram

f654111

Merge from upsteram

Merge branch 'master' of https://github.com/GeoNode/geonode

0df9357

[Fixes GeoNode#6914] Remove "add to basket" tool for documents and ma…

65c6267

…ps (GeoNode#6915)

Added malnajdi as contributor

158511a

- CircleCI Upload Tests: trying to reduce more the risk of infinite …

91f1a4e

…loop on "wait_for_progress"

- Algin setup.cfg to requirements.txt

ae6f6c1

[Fixes GeoNode#6922][REST API v2] Expose the curated thumbnail URL if…

0dad216

… it has… (GeoNode#6923) * [Fixes GeoNode#6922][REST API v2] Expose the curated thumbnail URL if it has been uploaded * - Add REST APIs test suite to CircleCI

[Fixes GeoNode#6918] Removal of QGIS support (GeoNode#6919)

30910b2

* [Cleanup and Refactor] Remove QGIS server backend dependencies * [Cleanup and Refactor] Remove QGIS server backend dependencies * - Fix LGTM issues

Merge branch 'master' of https://github.com/GeoNode/geonode

dbb4ac0

allow Basic authenticated requests in LOCKDOWN mode

0bcf2fb

fix to avoid circular import

af22a3c

flake8 check fix

c7ede4f

added tests

b557f6d

Merge pull request GeoNode#652 from geosolutions-it/feature#650_basic…

0a82a14

…_auth_middleware Feature#650 basic auth middleware

Merge pull request GeoNode#678 from geosolutions-it/upstream_master

11f40ba

Upstream master

Merge remote-tracking branch 'upstream/master'

482080a

Merge remote-tracking branch 'upstream/master'

2f70532

Merge branch 'master' of https://github.com/geosolutions-it/geonode

de43e90

Merge remote-tracking branch 'origin/master' into geosolutions-master

40408a3

Merge branch 'master' of https://github.com/GeoNode/geonode into geos…

4ce20ab

…olutions_master

giohappy and others added 4 commits April 22, 2021 11:18

Merge remote-tracking branch 'upstream/master'

706ea43

Merge remote-tracking branch 'origin/master' into geosolutions-master

711a619

Merge remote-tracking branch 'origin/master' into geosolutions-master

354764e

Merge branch 'master' of github.com:geosolutions-it/geonode

e18bc6f

meomancer changed the title ~~Remove get_default_access_permissions from harvester~~ [Fixes #7761] Harvested resource permissions assignment must follow the same logic as uploaded resources Jul 9, 2021

cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Jul 9, 2021

afabiani added this to the 4.0.0 milestone Jul 14, 2021

meomancer force-pushed the 301-remove-permission-from-harvester branch from 7d54f32 to 9d71ea0 Compare July 19, 2021 02:00

ricardogsilva self-requested a review July 21, 2021 09:22

Merge branch 'master' of github.com:GeoNode/geonode

e5cf581

giohappy self-requested a review July 22, 2021 08:07

giohappy requested changes Jul 22, 2021

View reviewed changes

Ricardo Garcia Silva and others added 2 commits July 22, 2021 17:14

Merge branch 'master' of github.com:GeoNode/geonode

06d2930

Remove get_default_access_permissions from harvester

ff589be

ricardogsilva force-pushed the 301-remove-permission-from-harvester branch from 9d71ea0 to ff589be Compare July 23, 2021 08:40

ricardogsilva approved these changes Jul 26, 2021

View reviewed changes

ricardogsilva requested a review from giohappy July 26, 2021 17:40

Merge branch 'master' into 301-remove-permission-from-harvester

2a59980

giohappy approved these changes Jul 27, 2021

View reviewed changes

giohappy merged commit 0de263c into GeoNode:master Jul 27, 2021

afabiani assigned meomancer Jul 27, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Fixes #7761] Harvested resource permissions assignment must follow the same logic as uploaded resources #7760

[Fixes #7761] Harvested resource permissions assignment must follow the same logic as uploaded resources #7760

meomancer commented Jul 9, 2021 •

edited

Loading

cla-bot bot commented Jul 9, 2021

meomancer commented Jul 9, 2021 •

edited

Loading

lgtm-com bot commented Jul 9, 2021

lgtm-com bot commented Jul 9, 2021

codecov bot commented Jul 9, 2021 •

edited

Loading

lgtm-com bot commented Jul 12, 2021

afabiani commented Jul 13, 2021

meomancer commented Jul 19, 2021

ricardogsilva commented Jul 21, 2021

giohappy left a comment

ricardogsilva left a comment

[Fixes #7761] Harvested resource permissions assignment must follow the same logic as uploaded resources #7760

[Fixes #7761] Harvested resource permissions assignment must follow the same logic as uploaded resources #7760

Conversation

meomancer commented Jul 9, 2021 • edited Loading

Checklist

cla-bot bot commented Jul 9, 2021

meomancer commented Jul 9, 2021 • edited Loading

lgtm-com bot commented Jul 9, 2021

lgtm-com bot commented Jul 9, 2021

codecov bot commented Jul 9, 2021 • edited Loading

Codecov Report

lgtm-com bot commented Jul 12, 2021

afabiani commented Jul 13, 2021

meomancer commented Jul 19, 2021

ricardogsilva commented Jul 21, 2021

giohappy left a comment

Choose a reason for hiding this comment

ricardogsilva left a comment

Choose a reason for hiding this comment

meomancer commented Jul 9, 2021 •

edited

Loading

meomancer commented Jul 9, 2021 •

edited

Loading

codecov bot commented Jul 9, 2021 •

edited

Loading