-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix & elide typescript errors; error fail CI build #162
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
import { useTranslation } from 'react-i18next' | ||
|
||
export function Head() { | ||
// @ts-expect-error HACK missing translations | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @serikjensen Do you know if we can use There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. no idea what happened here if it was a rename that didn't get updated, but for some reason it points to a file that doesn't exist. it should be
I have a fix for it included in this PR #159 (comment) i'm good with you just adding the comment here and then rebasing that signature form PR and fixing it there |
||
const { t } = useTranslation('Company.DocumentSigner') | ||
|
||
return <h2>{t('documentListTitle')}</h2> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,7 +12,7 @@ | |
"module": "ESNext", | ||
"moduleDetection": "force", | ||
"allowJs": true, | ||
"noEmit": false, | ||
"noEmit": true, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We don't actually compile with |
||
"jsx": "react-jsx", | ||
"moduleResolution": "bundler", | ||
"resolveJsonModule": true, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This felt like the best place to insert the typecheck. Broken types won't break your local dev build while you're working but will break both CI and publish here. There's some room for efficiency to run tsc and vite in parallel here but didn't feel worth right now.