Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linkage: enable cache by default. #4390

Merged
merged 1 commit into from
Jun 29, 2018
Merged

linkage: enable cache by default. #4390

merged 1 commit into from
Jun 29, 2018

Conversation

MikeMcQuaid
Copy link
Member

This has not been causing any issues in CI or for master users so let's now enable it by default for everyone.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@MikeMcQuaid
linkage: enable cache by default.
6f5c8b8 
This has not been causing any issues in CI or for `master` users so
let's now enable it by default for everyone.
@ghost ghost assigned MikeMcQuaid Jun 29, 2018
@ghost ghost added the in progress Maintainers are working on this label Jun 29, 2018
This was referenced Jun 29, 2018
Merged
Merged
@MikeMcQuaid MikeMcQuaid merged commit 376f67b into Homebrew:master Jun 29, 2018
@MikeMcQuaid MikeMcQuaid deleted the linkage-cache-default branch June 29, 2018 19:35
@ghost ghost removed the in progress Maintainers are working on this label Jun 29, 2018
iMichka added a commit to Linuxbrew/homebrew-test-bot that referenced this pull request Jul 11, 2018
@iMichka
Merge branch homebrew/master into linuxbrew/master
84ceb3e 
Merge pull request Homebrew#167 from commitay/high-sierra

brew-test-bot: run codecov on high sierra
brew-test-bot: run codecov on high sierra

Merge pull request Homebrew#165 from commitay/travis

travis.yml: update to xcode 9.4
Merge pull request Homebrew#166 from commitay/testbottest

Revert "testbottest: add bottle block"
Revert "testbottest: add bottle block"

This reverts commit fd79216.

travis.yml: update to xcode 9.4

Merge pull request Homebrew#164 from commitay/testbottest

testbottest: add bottle block
testbottest: add bottle block

Merge pull request Homebrew#163 from MikeMcQuaid/remove-linkage-cache

test-bot: don't enable linkage cache.
test-bot: use correct bottle domain variable.

test-bot: don't enable linkage cache.

After Homebrew/brew#4390 is merged this will be
enabled by default.

Closes #97.

Signed-off-by: Michka Popoff <[email protected]>
@lock lock bot added the outdated PR was locked due to age label Jul 29, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@MikeMcQuaid MikeMcQuaid

Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MikeMcQuaid