Merge branch homebrew/master into linuxbrew/master

Merge pull request Homebrew#167 from commitay/high-sierra

brew-test-bot: run codecov on high sierra
brew-test-bot: run codecov on high sierra

Merge pull request Homebrew#165 from commitay/travis

travis.yml: update to xcode 9.4
Merge pull request Homebrew#166 from commitay/testbottest

Revert "testbottest: add bottle block"
Revert "testbottest: add bottle block"

This reverts commit fd79216.

travis.yml: update to xcode 9.4

Merge pull request Homebrew#164 from commitay/testbottest

testbottest: add bottle block
testbottest: add bottle block

Merge pull request Homebrew#163 from MikeMcQuaid/remove-linkage-cache

test-bot: don't enable linkage cache.
test-bot: use correct bottle domain variable.

test-bot: don't enable linkage cache.

After Homebrew/brew#4390 is merged this will be
enabled by default.

Closes #97.

Signed-off-by: Michka Popoff <[email protected]>

.travis.yml

@@ -1,4 +1,5 @@
-language: c
+language: ruby
+rvm: system
 cache:
   directories:
     - $HOME/Library/Caches/Homebrew/style
@@ -12,10 +13,8 @@ matrix:
   fast_finish: true
   include:
     - os: osx
-      compiler: clang
-      osx_image: xcode9.2
+      osx_image: xcode9.4
     - os: linux
-      compiler: gcc
       sudo: false
 
 before_install:

cmd/brew-test-bot.rb

@@ -1447,7 +1447,7 @@ def test_ci_upload(tap)
       bottle_hash["bottle"]["tags"].each_value do |tag_hash|
         filename = tag_hash["filename"]
         bintray_filename_url =
-          "#{BottleSpecification::DEFAULT_DOMAIN}/#{bintray_repo}/#{filename}"
+          "#{HOMEBREW_BOTTLE_DOMAIN}/#{bintray_repo}/#{filename}"
         filename_already_published = if ARGV.include?("--dry-run")
           puts "curl -I --output /dev/null #{bintray_filename_url}"
           false
@@ -1535,7 +1535,6 @@ def sanitize_argv_and_env
     ENV["HOMEBREW_DEVELOPER"] = "1"
     ENV["HOMEBREW_NO_AUTO_UPDATE"] = "1"
     ENV["HOMEBREW_NO_EMOJI"] = "1"
-    ENV["HOMEBREW_LINKAGE_CACHE"] = "1"
     ENV["HOMEBREW_FAIL_LOG_LINES"] = "150"
     ENV["PATH"] =
       "#{HOMEBREW_PREFIX}/bin:#{HOMEBREW_PREFIX}/sbin:#{ENV["PATH"]}"
@@ -1559,7 +1558,7 @@ def sanitize_argv_and_env
 
     # Only report coverage if build runs on macOS and this is indeed Homebrew,
     # as we don't want this to be averaged with inferior Linux test coverage.
-    if OS.mac? && MacOS.version == :sierra && (ENV["CODECOV_TOKEN"] || travis)
+    if OS.mac? && MacOS.version == :high_sierra && (ENV["CODECOV_TOKEN"] || travis)
       ARGV << "--coverage"
     end