Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testbottest: add bottle block #164

Merged
merged 1 commit into from
Jul 5, 2018
Merged

testbottest: add bottle block #164

merged 1 commit into from
Jul 5, 2018

Conversation

commitay
Copy link
Contributor

@commitay commitay commented Jul 4, 2018

This adds a bottle block to satisfy the audit --online step of the travis brew tests.

Homebrew/brew#4420

@MikeMcQuaid
Copy link
Member

Maybe make this bottle disabled or unneeded instead? Want to ensure it’s always built from source for testing.

@commitay
Copy link
Contributor Author

commitay commented Jul 4, 2018

brew bottle doesn't seem to like disabled/unneeded.

Error: Formula has disabled bottle: testbottest
This formula doesn't require compiling.

@ilovezfs
Copy link
Contributor

ilovezfs commented Jul 4, 2018

Maybe could add a --force to brew bottle?

@MikeMcQuaid
Copy link
Member

What if this is bottle do with nothing else in it?

@commitay
Copy link
Contributor Author

commitay commented Jul 4, 2018

Empty bottle do block seems to work but it errors with --strict for bottle_block_cop.rb. Not sure if that's an issue or not.

An error occurred while FormulaAuditStrict/BottleBlock cop was inspecting ... testbottest
undefined method `metadata' for nil:NilClass

@commitay
Copy link
Contributor Author

commitay commented Jul 4, 2018

Pushed an empty block to see if CI likes it or not.

@MikeMcQuaid MikeMcQuaid merged commit 1661258 into Homebrew:master Jul 5, 2018
@MikeMcQuaid
Copy link
Member

Thanks again @commitay!

@commitay commitay deleted the testbottest branch July 5, 2018 07:55
iMichka added a commit to Linuxbrew/homebrew-test-bot that referenced this pull request Jul 11, 2018
Merge pull request Homebrew#167 from commitay/high-sierra

brew-test-bot: run codecov on high sierra
brew-test-bot: run codecov on high sierra

Merge pull request Homebrew#165 from commitay/travis

travis.yml: update to xcode 9.4
Merge pull request Homebrew#166 from commitay/testbottest

Revert "testbottest: add bottle block"
Revert "testbottest: add bottle block"

This reverts commit fd79216.

travis.yml: update to xcode 9.4

Merge pull request Homebrew#164 from commitay/testbottest

testbottest: add bottle block
testbottest: add bottle block

Merge pull request Homebrew#163 from MikeMcQuaid/remove-linkage-cache

test-bot: don't enable linkage cache.
test-bot: use correct bottle domain variable.

test-bot: don't enable linkage cache.

After Homebrew/brew#4390 is merged this will be
enabled by default.

Closes #97.

Signed-off-by: Michka Popoff <[email protected]>
@lock lock bot added the outdated label Jan 18, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants