Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gobdokumente: convert to on_system blocks #138579

Merged
merged 1 commit into from
Dec 28, 2022
Merged

gobdokumente: convert to on_system blocks #138579

merged 1 commit into from
Dec 28, 2022

Conversation

Rylan12
Copy link
Member

@Rylan12 Rylan12 commented Dec 27, 2022

Convert to on_system blocks

See #137512

@p-linnane
Copy link
Member

/rebase

@Rylan12
Copy link
Member Author

Rylan12 commented Dec 27, 2022

Remind me what we decided to do about Error: Upstream defined 10.16 as minimal OS version and the cask defined 10.11?

Edit: I misunderstood the error, I see

@p-linnane
Copy link
Member

For the 10.16 thing specifically we are setting it to 11 on the cask and sending a message to upstream asking them to change to 11. The audit fails, but we merge anyway.

@Rylan12
Copy link
Member Author

Rylan12 commented Dec 27, 2022

Okay, thanks!

Think we should just add a case to the audit to treat 10.16 as the same as 11?

Also, because of this, it's safe to remove the legacy version info, right? Since no one on those OS versions could install anyway because of the depends_on

@p-linnane
Copy link
Member

There is currently no logic in the audit for 10.16. I would implement it, but I'm not sure how 😄

@Rylan12
Copy link
Member Author

Rylan12 commented Dec 27, 2022

There is currently no logic in the audit for 10.16. I would implement it, but I'm not sure how 😄

Homebrew/brew#14297

@p-linnane p-linnane merged commit d7f91c9 into Homebrew:master Dec 28, 2022
@Rylan12 Rylan12 deleted the gobdokumente-on-system branch December 28, 2022 02:15
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants