Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Galois code review #3794

Merged
merged 24 commits into from
Jun 28, 2022
Merged

Galois code review #3794

merged 24 commits into from
Jun 28, 2022

Conversation

coot
Copy link
Contributor

@coot coot commented Jun 7, 2022

  • improve/add documentation
  • GR-FIXME: comments and fixme's from Galois Review
  • refactors

@coot coot added the networking label Jun 7, 2022
@coot
Copy link
Contributor Author

coot commented Jun 7, 2022

Changes pulled from the galois-review branch.

@coot coot force-pushed the coot/galois-review branch from 015f1ca to 8a00083 Compare June 7, 2022 12:24
@coot
Copy link
Contributor Author

coot commented Jun 7, 2022

I split the refactor commit, since the p2p part will quite likely conflict with PR #3785.

@coot coot requested review from bolt12 and dcoutts June 7, 2022 12:32
@coot coot force-pushed the coot/galois-review branch from 8a00083 to c26c388 Compare June 21, 2022 07:21
coot and others added 22 commits June 28, 2022 11:34
@coot @mtullsen
refactors
0976502 
Co-authored-by: Mark Tullsen <[email protected]>
@coot @mtullsen
refactor P2P api
20b5920 
Co-authored-by: Mark Tullsen <[email protected]>
@coot
Address review comments.
06fc4cd
@coot
Address comments regarding ControlChannel
8450ac1
@coot
Refused renaming of ProtocolTemperature
8cde3ec 
We use `Established` for mini-protocols which runs for warm and hot
peers (called established in the outbound governor), `Warm` for warm
mini-protocols, `Hot` for hot mini-protocols.  This is the same naming
convention as the governor.
@coot
Addressed review comments.
b1996cd
@coot
Renamed Bundle as TemperatureBundle
97c78c4
@coot
Race threads via foldl1.
bbb4a7d
@coot
Addressed review comments in diffusion
5365dac
@coot
Move P2P snocket utils to Ouroboros.Network.Diffusion.Utils module
af9b15b
@coot
Removed always true assertion
347fbc1
@coot
Renamed splitPeers and partitionPeer
fc04df7 
It just handles a single peer.
@coot
Fixed TOC of Ouroboros.Network.PeerStateActions haddocks
5f7fa6f
@coot
Removed PeerState date type
120ab5a 
We can use 'PeerStatus' instead.
@coot
Change type signature of withPeerSelectionActions
9c7ec0d
@coot
Renamed TokProtocolTemperature as SingProtocolTemperature
808fcc8
@coot
showConnectionEvents: removed unnecessary brackets
16a620a
@coot
JobPool: renamed collect to waitForJob
f4bfb6b
@coot
JobPool: improve haddocks, clean the code
051551a
@coot
Peer list lifetime constants, improved haddocks.
1f37a45
@coot
Added server_CONNABORTED_DELAY constant.
5433277
@coot
Move a comment to the right place
caba7ad
@coot coot force-pushed the coot/galois-review branch from d7c0957 to caba7ad Compare June 28, 2022 09:37
@coot
Copy link
Contributor Author

coot commented Jun 28, 2022

In the last push I fixed syntax (stylish-haskell).

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jun 28, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit 233ae41 into master Jun 28, 2022
@iohk-bors iohk-bors bot deleted the coot/galois-review branch June 28, 2022 12:50
This was referenced Oct 28, 2022
Closed
Merged
iohk-bors bot added a commit that referenced this pull request Nov 9, 2022
@iohk-bors @mtullsen @coot
Merge #4120
e933084 
4120: Cherry picked network changes for cardano-node-1.35.5 release r=coot a=coot

This cherry-picked patches from the following PRs:

* #3794
* #3844
* #3785
* #3904
* #3915
* #3852
* #3970
* #3979
* #4015
* #4067
* #4004
* #4086
* #4113
* #4106
* #4127
* #4103

Also cherry-picked almost all the commits which modify GitHub actions:
* 18c5244 Run GitHub Actions on pull requests   
* 3adf5a9 Use newer version of io-sim           
* ee9b7a6 Fix GH Actions Windows CI: switch from pkgconf to pkg-config 
* e6cf074 github-actions: use `ubuntu-latest`   
* 9a8b959 Updated versions of github actions    
* fc8f8f0 Fix GH Actions Windows CI caching     
* 7f07c40 Windows Github Actions now use MSYS2  
* b21a7ce Fix chocolatey CI error
* #4134               

TODO:

* [x] bump versions of packages
* [x] input-output-hk/cardano-haskell-packages#84

Co-authored-by: Mark Tullsen <[email protected]>
Co-authored-by: Marcin Szamotulski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bolt12 bolt12 bolt12 approved these changes

@dcoutts dcoutts Awaiting requested review from dcoutts

@nfrisby nfrisby Awaiting requested review from nfrisby

Assignees

@coot coot

Labels
technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review Galois Report
3 participants
@coot @bolt12 @mtullsen