Cherry picked network changes for cardano-node-1.35.5 release #4120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coot
force-pushed
the
coot/cardano-node-1.35.5
branch
from
47a1b86 to
44645ba
Compare
Co-authored-by: Mark Tullsen <[email protected]>
Co-authored-by: Mark Tullsen <[email protected]>
We use `Established` for mini-protocols which runs for warm and hot peers (called established in the outbound governor), `Warm` for warm mini-protocols, `Hot` for hot mini-protocols. This is the same naming convention as the governor.
It just handles a single peer.
We can use 'PeerStatus' instead.
For local connections the inbound governor should not force the idleness timeout. Some clients relay letting the connection idle after it was negotiated and before any mini-protocol is started. We keep the connection manager idle timeout, this is only used for outbound connections, and thus not related to `node-to-client` protocol.
By hiding `peerconn` we can simplify diffusion types. This is required if we want to add result type of protocols (on the initiator side).
ExitPolicy governs the delay for reconnecting either if any of the mini-protocol exists cleanly or throws an exception.
When any of the mini-protocol exits (either with an error or otherwise), we reactivation delay which is used by the outbound governor. It is expected that multiple mini-protocol exits roughly at the same time, e.g. in hot to warm transition `chain-sync`, `block-fetch` and `tx-submission` will terminate around the same time. For this reason the `setActivateTimes` is taking the maximum of the existing connect time and the new one, as well as the `ReconnectDelay` is an additive monoid.
For SPOs it's quite important to track these demotions. This trace must have a least `Warning` severity.
coot
force-pushed
the
coot/cardano-node-1.35.5
branch
from
e246646 to
fe28e03
Compare
newtork-mux-0.2.0.0 ouroboros-network-framework-0.2.0.0 ouroboros-network-0.2.0.0 ouroboros-consensus-0.1.0.2 (depends on `ouroboros-network ^>= 0.2`)
dnadales
approved these changes
Nov 8, 2022
coot
force-pushed
the
coot/cardano-node-1.35.5
branch
from
0628e47 to
efc3d4d
Compare
* cardano-base * cardano-ledger * plutus
coot
force-pushed
the
coot/cardano-node-1.35.5
branch
from
efc3d4d to
56f8fdd
Compare
disassembler
force-pushed
the
coot/cardano-node-1.35.5
branch
2 times, most recently
from
e7f5b16 to
d60553e
Compare
disassembler
force-pushed
the
coot/cardano-node-1.35.5
branch
from
d60553e to
8e3b963
Compare
|
bors merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cherry-picked patches from the following PRs:
Also cherry-picked almost all the commits which modify GitHub actions:
ubuntu-latestTODO: