Fix diffusion simulation error #3904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The show instance for `StdGen` does not allow to reconstruct it (the constructor is private), for this reason it's much better to pass the seed itself. This allows one to execute the failed case.
This is done in order to make the serialised version more usable when pasting from the console to a Haskell file. The changes touch: * 'TestAddress' * 'RelayAccessPoint' * 'NtNAddr_' * 'SimArg' * 'Command' Surround 'IP' address in `"` so it is a valid string. One still needs to add `read` in front of an IP address. For domain names, one can just enable 'OverloadedString' extension.
Now it's enough to just import Test.Ouroboros.Network.Testnet.Simulation.Node to get everything in scope for SimArgs. This makes it much easier to work with specific test failures reported by quickcheck.
Increased the interval for which we allow the local targets to be above the limit to 15 seconds. Fixed #3900
|
bors merge |
This was referenced Oct 28, 2022
iohk-bors bot
added a commit
that referenced
this pull request
Nov 9, 2022
4120: Cherry picked network changes for cardano-node-1.35.5 release r=coot a=coot This cherry-picked patches from the following PRs: * #3794 * #3844 * #3785 * #3904 * #3915 * #3852 * #3970 * #3979 * #4015 * #4067 * #4004 * #4086 * #4113 * #4106 * #4127 * #4103 Also cherry-picked almost all the commits which modify GitHub actions: * 18c5244 Run GitHub Actions on pull requests * 3adf5a9 Use newer version of io-sim * ee9b7a6 Fix GH Actions Windows CI: switch from pkgconf to pkg-config * e6cf074 github-actions: use `ubuntu-latest` * 9a8b959 Updated versions of github actions * fc8f8f0 Fix GH Actions Windows CI caching * 7f07c40 Windows Github Actions now use MSYS2 * b21a7ce Fix chocolatey CI error * #4134 TODO: * [x] bump versions of packages * [x] input-output-hk/cardano-haskell-packages#84 Co-authored-by: Mark Tullsen <[email protected]> Co-authored-by: Marcin Szamotulski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the
prop_diffusion_target_active_local_aboveand do a bit refactoring ofthe diffusion tests to make it easier to run quickcheck diffusion simulations
in
GHCi.Fixes #3900.
Checklist
interface-CHANGELOG.mdinterface-CHANGELOG.md