fix(kbadge): slotted link styles [KHCP-14774] #2585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kongponents-sandbox ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
adamdehaven
approved these changes
Jan 21, 2025
✅ Deploy Preview for kongponents ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kongponents-bot
pushed a commit
that referenced
this pull request
Jan 21, 2025
## [9.17.5](v9.17.4...v9.17.5) (2025-01-21) ### Bug Fixes * **kbadge:** slotted link styles [KHCP-14774] ([#2585](#2585)) ([6054bec](6054bec))
|
🎉 This PR is included in version 9.17.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
johncowen
added a commit
to kumahq/kuma-gui
that referenced
this pull request
Jan 24, 2025
### current master (I couldn't manage to get a grab with rollover, but it underlines):  ### With #3460 applied (the mouse is rolled over the link but the pointer isn't in the grab):  ### With this PR applied (the mouse is rolled over the link but the pointer isn't in the grab):  Introduced in Kong/kongponents#2585 I've mentioned a few times I kinda have a different approach to solve this sort of stuff completely, I might put up a draft PR soon. Related to: - Kong/kongponents#2559 - #3323 - #3317 --------- Signed-off-by: John Cowen <[email protected]>
johncowen
added a commit
to kumahq/kuma-gui
that referenced
this pull request
Jan 24, 2025
it underlines):  is rolled over the link but the pointer isn't in the grab):  pointer isn't in the grab):  Introduced in Kong/kongponents#2585 I've mentioned a few times I kinda have a different approach to solve this sort of stuff completely, I might put up a draft PR soon. Related to: - Kong/kongponents#2559 - #3323 - #3317 --------- Signed-off-by: John Cowen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses: https://konghq.atlassian.net/browse/KHCP-14774
Fixes slotted link styles in KBadge
Before
After
Also fixes
selector-pseudo-class-no-unknownstylelint flagging:deepselector (screenshot)