Skip to content

Commit

Permalink
fix: maintain tag anchor and key:value styling in KBadges (#3462)
Browse files Browse the repository at this point in the history
it underlines):

![Screenshot 2025-01-24 at 14 23
55](https://github.com/user-attachments/assets/1174fabb-e5e7-45ee-afec-df4ec3769fde)

is rolled over the link but the pointer isn't in the grab):

![Screenshot 2025-01-24 at 14 18
00](https://github.com/user-attachments/assets/8b096d74-d29c-4ce6-beff-3285e3e73933)

pointer isn't in the grab):

![Screenshot 2025-01-24 at 14 17
08](https://github.com/user-attachments/assets/3a65998b-59fb-4f4b-9697-095c3072063d)

Introduced in Kong/kongponents#2585

I've mentioned a few times I kinda have a different approach to solve
this sort of stuff completely, I might put up a draft PR soon.

Related to:

- Kong/kongponents#2559
- #3323
- #3317

---------

Signed-off-by: John Cowen <[email protected]>
  • Loading branch information
johncowen committed Jan 24, 2025
1 parent 5017e39 commit 7f3567d
Showing 1 changed file with 10 additions and 5 deletions.
15 changes: 10 additions & 5 deletions packages/kuma-gui/src/app/common/TagList.vue
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
:is="tag.route ? 'XAction' : 'span'"
:to="tag.route"
>
{{ tag.label }}:<b>{{ tag.value }}</b>
<span class="label">{{ tag.label }}</span>:<span class="value">{{ tag.value }}</span>
</component>
</XBadge>
</component>
Expand Down Expand Up @@ -113,11 +113,16 @@ function getRoute(tag: LabelValue): RouteLocationNamedRaw | undefined {
justify-content: flex-end;
}
.tag {
font-weight: $kui-font-weight-regular;
}
.tag :deep(a) {
color: currentColor;
}
.tag :deep(a):hover {
text-decoration: underline;
}
.tag :deep(span.label) {
font-weight: $kui-font-weight-regular;
}
.tag :deep(span.value) {
font-weight: $kui-font-weight-semibold;
}
</style>

0 comments on commit 7f3567d

Please sign in to comment.