fix: upgrade button text color #3317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Cowen <[email protected]>
✅ Deploy Preview for kuma-gui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This was referenced Dec 19, 2024
johncowen
added a commit
that referenced
this pull request
Jan 6, 2025
Fixes text color of all primary buttons within alerts. See Kong/kongponents@84a4e9f I previously "fixed" this in #3317 just for our upgrade button, thinking this was the only instance This PR undoes that ^ PR and fixes it globally instead, which will fix the issue for all instances whether I remember about them or not. ### Before <img width="816" alt="Screenshot 2024-12-19 at 11 22 19" src="https://github.com/user-attachments/assets/a0341a9d-a2bc-47cc-b856-366f27d119ea" /> ### After <img width="813" alt="Screenshot 2024-12-19 at 11 08 31" src="https://github.com/user-attachments/assets/472eff96-54b2-4573-bcd9-1ece0a7eb31e" /> --------- Signed-off-by: John Cowen <[email protected]>
johncowen
added a commit
that referenced
this pull request
Jan 24, 2025
### current master (I couldn't manage to get a grab with rollover, but it underlines):  ### With #3460 applied (the mouse is rolled over the link but the pointer isn't in the grab):  ### With this PR applied (the mouse is rolled over the link but the pointer isn't in the grab):  Introduced in Kong/kongponents#2585 I've mentioned a few times I kinda have a different approach to solve this sort of stuff completely, I might put up a draft PR soon. Related to: - Kong/kongponents#2559 - #3323 - #3317 --------- Signed-off-by: John Cowen <[email protected]>
johncowen
added a commit
that referenced
this pull request
Jan 24, 2025
it underlines):  is rolled over the link but the pointer isn't in the grab):  pointer isn't in the grab):  Introduced in Kong/kongponents#2585 I've mentioned a few times I kinda have a different approach to solve this sort of stuff completely, I might put up a draft PR soon. Related to: - Kong/kongponents#2559 - #3323 - #3317 --------- Signed-off-by: John Cowen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After
Another possibly temporary fix for the above. This came in with a bump of
@kong/kongponentsfrom9.14.20to9.14.24today (#3308) I'm just looking into it.I think its this Kong/kongponents@84a4e9f (trying to find the PR for this, is it me or isn't there one? 🤔 ) which is related to one of our own issues here #3260