Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the "ok" in M280, M301, M304, M851 with output not including … #2983

Merged
merged 1 commit into from
Feb 18, 2016

Conversation

AnHardt
Copy link
Contributor

@AnHardt AnHardt commented Feb 9, 2016

…an "ok"

Replace the "ok" in M280, M301, M304, M851 with output not including an "ok"
to avoid senting two "ok"s for a single g-code.

Doing the same for M105 would break the input filters of the hosts.
For M105 the other "ok" is omitted.
#2911 #2950

…an "ok"

Replace the "ok" in M280, M301, M304, M851 with output not including an "ok"
to avoid senting two "ok"s for a single g-code.

Doing the same for M105 would break the input filters of the hosts.
For M105 the other "ok" is omitted.
@thinkyhead
Copy link
Member

This is fine to merge now. Do we have a similar patch for the MarlinDev branch yet?

thinkyhead added a commit that referenced this pull request Feb 18, 2016
Replace the "ok" in M280, M301, M304, M851 with output not including …
@thinkyhead thinkyhead merged commit 0c9db67 into MarlinFirmware:RCBugFix Feb 18, 2016
@AnHardt
Copy link
Contributor Author

AnHardt commented Feb 18, 2016

@thinkyhead
No we have not.
My experience over the last few month is that non of my PRs was merged, but i had to update/rebase them constantly. I'm not mad enough anymore to do that also in different repositorys.

@AnHardt AnHardt deleted the ok-echo branch February 18, 2016 14:58
@thinkyhead
Copy link
Member

I'm not mad enough anymore to do that also in different repositories.

I might be just insane enough to do it, even for PRs that I didn't make. I think it's worth making a PR, even if it never gets rebased/merged, if only as a placeholder to remind us that the patch is needed. (It's easier to find a PR than an Issue.) But, I have also occasionally just compared the two code-bases to made a PR with all the differences that aren't already in a PR, and that continues to work as a fine strategy, since the code is mostly the same right now.

@AnHardt
Copy link
Contributor Author

AnHardt commented Feb 19, 2016

@thinkyhead
Since you are back, i'm not that hopeless anymore.

@thinkyhead
Copy link
Member

Since you are back, i'm not that hopeless anymore.

I had to take a break and let the chips fall where they may, but I hoped that the best contributors would not fly away, as so many others have. I'm glad to find you still here fighting the good fight!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants