-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Marlin RC-4 (RCBugFix) almost stable! Going final soon! #3154
Comments
Thanks for the heads up. Any news about the Full Graphics LCD slowness fix? |
@AnHardt made a good proposal for the LCD speed up but IMHO it's not ready to go into this release. |
@Roxy-3DPrintBoard will try the new RC4 in the weekend on my Mendel and On 16 March 2016 at 04:44, João Brázio [email protected] wrote:
|
@jbrazio |
I'm starting to think there will be an RC-5 after all. There are more outstanding Pull Requests (with important bug fixes) than I realized. |
Do we have a changelog for this RC version ? I'm not talking about |
No. It's kind of like the documentation issue. We need some help trying to dot all the i's and cross the t's. We don't seem to be very good at documenting things. |
Here's my priority to-do list for release. Basically, critical bug-fixes and obvious bug-fixes should go into The obvious ones are:
These should go into
The next PR, #3082, would be great to have in
I'll do as much testing and integration as I can tonight. Over the next day or two we can take care of any remaining polish needed for |
If I could add to RC5 wish list it would be automatic mesh leveling as it seems to be a often requested feature. But maybe this can turn out to be a project on its own, I never tried to evaluate the required effort. We see some questions about the thermal protection which should also be addressed, maybe try out releasing RC4 with the more relaxed default set proposed by @Blue-Marlin as see how it goes on the wild ? |
The Release Process
|
I keep flowcharting things as they are, and this has led to some good insights. Also, collecting all the code corresponding to a feature in one place. I think instead of just focusing on automating Mesh Bed Leveling (though, I kind of want to take a shot at this soon) we should also apply the manual leveling system to the other two leveling equations, following the same model as the current Manual Bed Leveling (that comes with Mesh Bed Leveling), which is very clean. The process of splitting these up conceptually should yield a better system for future expansion. (We should also investigate how far this kind of work has already progressed in the MarlinDev branches.) By slotting this feature for 1.1.1 instead of 1.1.0 it frees up the option to "overhaul" the leveling settings, if necessary. –– That's the kind of change that usually deserves a small version bump. The units we need:
|
I get confused easily. But I think I'm hearing you say that Automatic Mesh Bed Leveling that is not even fully written yet is way too big, complicated and untested to sneak into a Release Candidate. If that is what you are saying, I'm in agreement. |
That is an impressive list of changes! For RC-5, let's commit to only making changes that fix bugs. We need to get things to stabilize. |
@thinkyhead RC3 seems to work extremely well for me. So I'm happy to move to RC-4 and start testing. |
We need 20x of you. |
|
Todays RCBugFix(32f7574) feels very well. It only needs #3186, #3187 to be good enough for a release. For #3182 (Add support for Printrboard RevF) i see low potential to break something else. |
It actually needed changes to handle Cartesian Machines also. We need a couple of Cartesian Machines to load it and give a Thumbs Up.
This one feels important to get included just because so many machines are now having probes that are triggered when they are stowed. Can we get this one checked out to see if it can be included? Ideally, we would want to verify that neither the triggered or not triggered state does not have any impact when the probe is stowed. |
@thinkyhead Note about the list. I see #2978: Apply Mesh Bed Leveling matrix when switching extruders. But when looking at #2978 its about ABL. |
@Roxy-3DPrintBoard |
@epatel I will double-check the titles I gave to the PRs. I generated the original list using some command piping and regex in BASH and it may have munged some of the number-title correspondences. |
#3082 was one of those I was on the fence about. The description it included convinced me it was well thought out, pretty well constrained, and relatively straightforward. I couldn't find any fault with the logic in the code itself. And there are a couple of issues it would seem to address even beyond its immediate target, For me the question was whether it was better to get it into the hands of users or to leave the issue of unwanted probe readings unaddressed in RC4. My confidence level is about 80% that the idea will work like a charm. The 20% I hold in reserve is for spots where it may yet need to be applied. But we can take a closer methodical look at it and see how we feel in toto. But let me ask @AnHardt … How do you feel about #3082 and adding the new Anyway, I'm giving another day or two to see what shakes out of |
@thinkyhead will this be the last RC or do you plan for another round ? |
@jbrazio If RC4 can survive a week without getting flagged with any "serious" bugs, it might end up being the final release. But, if we end up fixing any "tricky" issues, we may want to do just one more RC# with a very short and constrained patch cycle, Either RC4 or the RC5 will definitely be the official release, and I would like to aim for April 1st, no fooling. |
I think there is a lot of room for debate on this. All opinions are welcome and deserve to be considered. But the way I'm coming at it, if a probe is not deployed (or engaged), the values it returns should not be looked at or used. That is kind of independent of how we make it easier for the user. And really... This seems like a good point in time for somebody to introduce a Probe Object. (But NOT in the Release Candidate) We don't even need one object that handles all cases. We just need to be able to select which probe object (fixed, manually deployed, kicked down with a servo, Z-Min EndStop, etc.) that is going to be used.
With this many changes... My guess is the odds of us not seeing some bad behavior in RC-4 is low. |
As far i can read my own messages above i said, 'part of a bigger plan' and 'not right now'. Of course. That area needs simplification. Especially the old descriptions are more confusing than enlightening the matter. Some of the options can be avoided at all. The right grouping seems to be important To get an impression of my plan: The logic has to be reversed from Do we have a probe? Than we can define one kind if probe.
Per probe type there could be predefined selections of probe actions - maybe in separate files.
//// probe()
//// refresh for 'E'()
//// stow()
// return to x,y If the probe is an object or not, does not matter. We need 4 functions/methods (deploy, probe, refresh, stow). All ending at the same x/y they started. Than probe handling for the calling function is trivial. Targets:
|
Makes sense your suggestion, what we have now might be named "assisted manual leveling" as Marlin is assisting you to go trough points. |
I think it is very common to have a 'Problem Area' on your bed and/or Mesh. Being able to adjust and edit the Mesh for these areas is important. One thing I'm looking at is allowing the adjustment of any random point as opposed to the actual Mesh Points. By doing a Bi-linear correction to the four points around the random position being corrected, it may be possible to push and pull the Mesh into the correct shape easier. |
Sounds like something better solved with a bit of glass.
|
This might be true on a Cartesian printer. But for a Delta, a perfectly flat piece of glass won't fix the issues. And besides... It's a fun piece of code to write! |
@paulusjacobus Sounds like something we should add to the new documentation. We need a page for each board that we support, probably, just to explain the quirks. PB RevF sounds like one of the more quirky ones. |
There probably needs to be a longer initial period, when the hot-end is more cold, then after that, the heating speed may tend to increase. Ideally it would be nice to automate this tuning, like Anyway, I will relax it to 2 degrees in 20 seconds, which should be more than enough time even initially. (#3262) |
I have noticed that the PID as it approaches the set temp, can
|
A well-tuned PID shouldn't fall back too far. Anyway, as soon as the heating is within the "hysteresis" range, the |
@paulusjacobus The Printrboard does not use the PJRC bootloader, thus the necessity for Atmel FLIP to be installed to flash. The teensyduino libraries are required for the MCU to function since Arduino never added official support for the AT90USB1286. The Reprap wiki has full instructions on how to flash the Printrboard ( Linux and Mac support is limited at the moment). |
@StephS How much work would it be to get the PrintRboard cleaned up and working well with Marlin? |
You mean changes to the physical board? or to Marlin? Support is added and thinkyhead merged. The issues were minor, like pin configuration and support for the DAC. The real issue is that Arduino does not natively support the AT90USB1286. You would need to develop and push a new library to Arduino, and even then you wouldn't have native programming. The AT90USB uses native USB instead of FTDI or another MCU, so special software is required to program, or programming a new bootloader (experimental). Since there is a lot of risk in programming the bootloader, it's better to use Atmel FLIP. |
My understanding is that the official boards from Printrbot use the DFU Both bootloaders require a jumper to be installed and reset to initiate
|
Can you not use PlatformIO, which does support the chipset with the
|
I had a look at PlatformIO which supports the Arduino (Mega) and Teensy On 29 March 2016 at 10:32, Tim Hawkins [email protected] wrote:
|
I can confirm it works with mega.
|
There is a platformio support folder on RC4 which I belive has a definition I normally use a ramps card, so to compile and upload to my card cd PlatformioAddons The value after the -e is the environment name, which is one of the listed -t upload Tells it to upload after compiling, if you leave that off it just compiles
|
Thank You for the extra PrintRBoard information! The reason I'm asking is my first printer has a PrinteRBoard in it. I just wanted to know if I needed to be aware of anything. PrintRBoard's have always had a problem of not being supported well by Arduino. I got v.1.05 going with my board but I now need to get moved to the latest Arduino since we are going to start enforcing its use (because of suspected compiler bugs). |
The arduino framework inside platformio is based on 1.6.7, the compilers
|
I had a look at the platformIO definition, there would need to be another entry for the RevF board since the pin use changed from the other rev boards. |
You have to select a different board I belive, board no 811 vs 81 for the Here is the snippet from boards.h that has the relevant stuff #define BOARD_PRINTRBOARD 81 // Printrboard (AT90USB1286)
|
@Roxy-3DPrintBoard I managed to compile the Marlin code for Rev F without On 29 March 2016 at 23:37, Roxy-3DPrintBoard [email protected]
|
@paulusjacobus With which version of the compiler? Hopefully, with the latest v.1.6.8 ! |
@Roxy-3DPrintBoard Yes version 1.6.8 and I even have installed 1.6.9 but On 30 March 2016 at 10:03, Roxy-3DPrintBoard [email protected]
|
One query I have with the firmware, |
All needed info is in the answer to M105. All the host has to do, is to evaluate that info. |
As we're onto patching RC5 towards RC6 (no doubt the final RC) this can close. |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This post is just a head up for everybody using Marlin on their 3D-Printers. Release Candidate #4 is getting very stable and the bug reports have dropped off to mostly being support questions. Very soon, we expect to promote RCBugFix to be the new, official, stable release of Marlin. If you know of any issues with RC-4, please let us know about them ASAP!
I've also alerted the users over at RepRap.org and 3DPrintBoard of the status:
http://forums.reprap.org/read.php?415,639920
http://3dprintboard.com/showthread.php?20851-Marlin-RC-4-(RCBugFix)-almost-stable!-Going-final-soon!&p=83325#post83325
PS. A really big Thank You! to ThinkyHead for his taking point on this effort.
The text was updated successfully, but these errors were encountered: