Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.1.0-RC4 #3104

Closed
wants to merge 1 commit into from
Closed

Release 1.1.0-RC4 #3104

wants to merge 1 commit into from

Conversation

thinkyhead
Copy link
Member

Over the weekend I integrated the most high-confidence patches with RCBugFix for RC4. This may not be the final release candidate, but it takes care of several longstanding and nagging bugs that exist in RC3. I feel pretty confident in the changes between RC3 and the current RC4, but if there are any side-effects of these patches I'm sure we'll know about them soon.

Issues to consider for RC5, or for the following release 1.1.1:

  • Improved feedback to hosts during busy periods, while pausing, and while awaiting input
  • I would like see Use a serial line buffer to prevent queue corruption #3012 (or equivalent) merged to prevent serial buffer corruption
  • Roxy's updated M48 for DELTA needs testing, and would be good to see updated also

@thinkyhead thinkyhead added Needs: More Data We need more data in order to proceed T: Development Makefiles, PlatformIO, Python scripts, etc. labels Mar 7, 2016
@jbrazio
Copy link
Contributor

jbrazio commented Mar 7, 2016

@thinkyhead you should have a look at #3102 it's a bug on RC4 with possible high visibility because affects G28.

@G-Forge
Copy link

G-Forge commented Mar 9, 2016

Release 1.1.0-RC4 and the only change from downloaded version is to uncomment #define AUTO_BED_LEVELING_FEATURE
compiles with this error:

Arduino: 1.6.7 (Windows 10), Board: "Arduino/Genuino Mega or Mega 2560, ATmega2560 (Mega 2560)"
sketch\Marlin_main.cpp: In function 'void run_z_probe()':
Marlin_main.cpp:1334: error: 'st_get_axis_position_mm' was not declared in this scope
       zPosition = st_get_axis_position_mm(Z_AXIS);
                                                 ^
sketch\Marlin_main.cpp: In function 'void gcode_G29()':
Marlin_main.cpp:3158: error: 'st_get_axis_position_mm' was not declared in this scope
               real_z = st_get_axis_position_mm(Z_AXIS);  //get the real Z (since plan_get_position is now correcting the plane)
                                                      ^
sketch\Marlin_main.cpp: In function 'void gcode_M48()':
Marlin_main.cpp:3605: error: 'st_get_axis_position_mm' was not declared in this scope
     double X_current = st_get_axis_position_mm(X_AXIS),
                                                      ^
Marlin_main.cpp:3615: error: 'X_probe_location' was not declared in this scope
       X_probe_location = code_value() - X_PROBE_OFFSET_FROM_EXTRUDER;
       ^
Marlin_main.cpp:3623: error: 'Y_probe_location' was not declared in this scope
       Y_probe_location = code_value() -  Y_PROBE_OFFSET_FROM_EXTRUDER;
       ^
Marlin_main.cpp:3645: error: 'Y_current' was not declared in this scope
     plan_buffer_line(X_current, Y_current, Z_start_location, E_current, homing_feedrate[Z_AXIS] / 60, active_extruder);
                                 ^
Marlin_main.cpp:3645: error: 'Z_start_location' was not declared in this scope
     plan_buffer_line(X_current, Y_current, Z_start_location, E_current, homing_feedrate[Z_AXIS] / 60, active_extruder);
                                            ^
Marlin_main.cpp:3645: error: 'E_current' was not declared in this scope
     plan_buffer_line(X_current, Y_current, Z_start_location, E_current, homing_feedrate[Z_AXIS] / 60, active_extruder);
                                                              ^
Marlin_main.cpp:3656: error: 'X_probe_location' was not declared in this scope
     plan_buffer_line(X_probe_location, Y_probe_location, Z_start_location,
                      ^
Marlin_main.cpp:3656: error: 'Y_probe_location' was not declared in this scope
     plan_buffer_line(X_probe_location, Y_probe_location, Z_start_location,
                                        ^
Marlin_main.cpp:3664: error: 'Z_current' was not declared in this scope
     current_position[Z_AXIS] = Z_current = st_get_axis_position_mm(Z_AXIS);
                                ^
exit status 1
'st_get_axis_position_mm' was not declared in this scope

  This report would have more information with
  "Show verbose output during compilation"
  enabled in File > Preferences.

@Blue-Marlin
Copy link
Contributor

The origin branch has only the needed changes to make RCBugFix into RC4 when it's time for that.
RCBugFix has moved on. Try RCBugFix instead. Your problem is solved there.

@thinkyhead
Copy link
Member Author

Change Log for Marlin 1.1.0-RC4 – as compared to RC3

CoreXY and CoreXZ:

Hosts, GCode:

LCD Controllers and SD cards:

Minor bugs:

Homing, Bed Leveling:

New and Experimental Features:

Configurations:

And...

@thinkyhead
Copy link
Member Author

Something for people fielding bugs to remember: In some cases we may get reports of what seem to be regressions, but what are actually the result of bug-fixes, because users may have found settings that worked around bugs in previous versions, and those settings no longer work with the repaired code. So watch out for those!

@thinkyhead
Copy link
Member Author

If we test #3069 and #3082 today, I bet they could be included in RC4. Particularly, the PR to disable sensors when not in use seems pretty good. The M48 delta extension seems ready to test, at least, so if we mark it with a warning as Very New, I think it's safe to assume mainly the hardcore probe hackers will be the most likely to use it and give feedback…

Adding: @Roxy-3DPrintBoard @AnHardt

@thinkyhead thinkyhead closed this Mar 24, 2016
@thinkyhead thinkyhead deleted the Release-1.1.0-RC4 branch March 24, 2016 14:42
@jbrazio jbrazio modified the milestone: 1.1.0 Jul 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs: More Data We need more data in order to proceed T: Development Makefiles, PlatformIO, Python scripts, etc.
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@thinkyhead @jbrazio @G-Forge @Blue-Marlin