Check probes only when deployed #3082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkyhead
force-pushed
the
updated_2820
branch
2 times, most recently
from
417379a to
6ea0b92
Compare
thinkyhead
force-pushed
the
updated_2820
branch
from
b94a0df to
177d0a5
Compare
thinkyhead
force-pushed
the
updated_2820
branch
6 times, most recently
from
fa666f5 to
3e12ccd
Compare
Aim: Test probes in update_endstops only when activated Changes: Configurations Add define for FIX_MOUNTED_PROBE to handle the situation where formerly ENDSTOPS_ONLY_FOR_HOMING had to be set, or lowering the nozzle below Z_PROBE_OFFSET_FROM_EXTRUDER could give an "endstop hit" message. Add define for Z_MIN_PROBE_USES_Z_MIN_ENDSTOP_PIN to indicate a common situation, that we have a probe but it is connected to an endstop pin Add some comments Shift some entries to have related things together. Conditionals.h We have a probe (HAS_Z_MIN_PROBE) if one of the pins is defined AND one of the probes is defined. SanityCheck.h Add some tests if the probe is connected and if we have defined a probe. stepper.cpp Changes to test the probe only when it is deployed (z_probe_is_active). Test update_endstops() when the probe is deployed. MarlinMain.cpp a. set and reset z_probe_is_active in deploy_z_probe(), stow_z_probe() and dock_sled() b. set and reset z_probe_is_active in the case a z-servo is moved to a defined position. The only remaining unhandled servo move is in M280 where we do not end in a defined position. If you want to handle a probe use M401/402 c. skip deploying/stowing when already deployed/stowed in the dedicated deploy/stow functions. d. Handle the new FIX_MOUNTED_PROBE in parallel to a servo driven probe/endstop. To do: In another PR. handle all probes in deploy/stow_z_probe. Sort out SERVO_LEVELING vs. HAS_SERVO_ENDSTOPS.
thinkyhead
force-pushed
the
updated_2820
branch
from
3e12ccd to
3f45a1a
Compare
Closed
thinkyhead
added a commit
that referenced
this pull request
Mar 21, 2016
This is quite comprehensive. If probes are disabled in any case when they shouldn't be, I'm sure we will hear about it soon.
ghost
mentioned this pull request
ghost
mentioned this pull request
Closed
thinkyhead
added a commit
to thinkyhead/Marlin
that referenced
this pull request
Mar 23, 2016
The reverses all the changes from PR MarlinFirmware#3082 pending further investigation.
thinkyhead
added a commit
that referenced
this pull request
Mar 24, 2016
Follow-up the PR #3082, etc
thinkyhead
added a commit
to thinkyhead/Marlin
that referenced
this pull request
Mar 24, 2016
The reverses all the changes from PR MarlinFirmware#3082 pending further investigation.
This was referenced Mar 25, 2016
Merged
drewmoseley
pushed a commit
to drewmoseley/Marlin
that referenced
this pull request
Nov 8, 2023
Keep consistent formatting for issue template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to #2820 for original PR