Option to reverse the click-wheel direction in menus #3114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkyhead
changed the title
thinkyhead
force-pushed
the
rc_reverse_lcd_menu
branch
from
c703040 to
91856cc
Compare
| @@ -1381,7 +1429,7 @@ static void lcd_control_volumetric_menu() { | |||
| lcd_implementation_drawedit(editLabel, _strFunc(((_type)((int32_t)encoderPosition + minEditValue)) / scale)); \ | |||
| if (isClicked) { \ | |||
| *((_type*)editValue) = ((_type)((int32_t)encoderPosition + minEditValue)) / scale; \ | |||
| lcd_goto_menu(prevMenu, prevEncoderPosition); \ | |||
| lcd_goto_menu(prevMenu, false, prevEncoderPosition); \ | |||
There was a problem hiding this comment.
After editing return to the selected line in the menu.
thinkyhead
force-pushed
the
rc_reverse_lcd_menu
branch
3 times, most recently
from
824ea6a to
d3cdb01
Compare
|
Wow! Congratulations. |
|
Only 1394 issues ago? That's what I call turnaround. |
thinkyhead
force-pushed
the
rc_reverse_lcd_menu
branch
from
d3cdb01 to
279d563
Compare
thinkyhead
force-pushed
the
rc_reverse_lcd_menu
branch
from
47daf0b to
a6bb3ca
Compare
thinkyhead
force-pushed
the
rc_reverse_lcd_menu
branch
from
a6bb3ca to
cc291ae
Compare
thinkyhead
added a commit
that referenced
this pull request
Mar 18, 2016
Option to reverse the click-wheel direction in menus
This was referenced Mar 19, 2016
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In answer to #1720. Add an option to reverse the menu navigation direction using the click-wheel.
Currently in Marlin: When navigating menus on the LCD you rotate clockwise to move the menu highlight down and counter-clockwise to move the menu highlight up.
Background: Some users have noted that if the click wheel is located to the right of the screen, the edge of the wheel next to the screen will be moving in the opposite direction from the menu navigation. Previously it has been suggested to simply change the pin numbers so that the wheel is reversed, but this results in problems with editing values. So we needed a way to be able to turn this behavior on and off, or to have the menus interpret the wheel direction in a different way from other code.
Investigation: We quickly uncover that there is a single place in the code where wheel pulses are turned into changes in the encoder value, and functions can pre-set the encoder value to whatever they want before reading changes to it. Menu functions, for example, use the current encoder value to decide what to highlight and when to scroll.
The Solution: 1. Add the ability to reverse the direction of the wheel at the lowest level. 2. Reverse the direction in most instances – whenever
START_MENUis applied. Set it forward for the editing of values, status screen, and any other non-menu contexts.See also MarlinFirmware/MarlinDev#384