Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #3160 MESH_BED_LEVELING broke correct G1 movement in Z #3164

Merged
merged 1 commit into from
Mar 16, 2016

Conversation

epatel
Copy link
Contributor

@epatel epatel commented Mar 16, 2016

Now on branch RCBugFix.
See #3160
Not tested, but fairly certain this cover adding same linear fix for Z as for E.

@thinkyhead
Copy link
Member

@epatel Does this patch need to be applied to dev also?

@epatel
Copy link
Contributor Author

epatel commented Mar 16, 2016

@thinkyhead dev? Maybe, I don't know what the current recommended "process" is. @Roxy-3DPrintBoard mentioned RCBugFix so I added it here.

@thinkyhead
Copy link
Member

Well, at the moment the MarlinDev repository is in a holding pattern while we get RCBugFix patched up and ready for RC4. So whenever any change is made to RCBugFix I've been making an equivalent PR against the MarlinDev/dev branch, as an explicit reminder that the change still needs to be applied. At some later point I will need to compare the code between the two code-bases to find any changes that may have been missed. But I'd like to make sure that contributors get their due credit and Github reputation points for the commits they're contributing, so a PR by the original author is best.

thinkyhead added a commit that referenced this pull request Mar 16, 2016
Fix for #3160 MESH_BED_LEVELING broke correct G1 movement in Z
@thinkyhead thinkyhead merged commit e8fa843 into MarlinFirmware:RCBugFix Mar 16, 2016
@jbrazio jbrazio modified the milestone: 1.1.0 Jul 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants