Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.16.0 #189

Closed
wants to merge 6 commits into from
Closed

v0.16.0 #189

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f8e5846
v0.16.0
bergarces Jun 15, 2023
8790bf9
fix changelog
bergarces Jun 15, 2023
3cfa1a5
rewording
bergarces Jun 16, 2023
e06cb5a
rewording
bergarces Jun 16, 2023
2926425
bump to 1.0.0
bergarces Jun 16, 2023
117719f
typo
bergarces Jun 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

## [0.16.0]
### Changed
- **BREAKING:** Refactor code to split keyring from bridge logic. ([#156](https://github.com/MetaMask/eth-ledger-bridge-keyring/pull/156))
Gudahtt marked this conversation as resolved.
Show resolved Hide resolved
- Migrate code to TypeScript. ([#174](https://github.com/MetaMask/eth-ledger-bridge-keyring/pull/174))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be two entries: one for the added types (non-breaking), and one for the change from default export to named export (breaking).

Anything else worth noting here @mikesposito ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.


## [0.15.0]
### Changed
- **BREAKING:** @ethereumjs/tx upgraded to major version 4, which includes a shift from storing numerical values as BNs to storing them as native BigInts. This is a breaking change for users of this keyring who access the values of the tx object, or that use those tx objects to interact with other libraries that depend on @ethereumsjs/tx versions under 4.0.0. ([#181](https://github.com/MetaMask/eth-ledger-bridge-keyring/pull/181))
Expand Down Expand Up @@ -57,7 +62,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Added
- Support new versions of ethereumjs/tx ([#68](https://github.com/MetaMask/eth-ledger-bridge-keyring/pull/68))

[Unreleased]: https://github.com/MetaMask/eth-ledger-bridge-keyring/compare/v0.15.0...HEAD
[Unreleased]: https://github.com/MetaMask/eth-ledger-bridge-keyring/compare/v0.16.0...HEAD
[0.16.0]: https://github.com/MetaMask/eth-ledger-bridge-keyring/compare/v0.15.0...v0.16.0
[0.15.0]: https://github.com/MetaMask/eth-ledger-bridge-keyring/compare/v0.14.0...v0.15.0
[0.14.0]: https://github.com/MetaMask/eth-ledger-bridge-keyring/compare/v0.13.0...v0.14.0
[0.13.0]: https://github.com/MetaMask/eth-ledger-bridge-keyring/compare/v0.12.0...v0.13.0
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@metamask/eth-ledger-bridge-keyring",
"version": "0.15.0",
"version": "0.16.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts on making this v1 instead? @gantunesr and I are in agreement that it seems appropriate

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've bumped the version, but I cannot change the branch name.

I've created a new PR with the correct branch name and all the changes discussed: #191

"description": "A MetaMask compatible keyring, for ledger hardware wallets",
"keywords": [
"ethereum",
Expand Down