Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.3] Skip to amount to buy when region is selected #4442

Merged
merged 38 commits into from
Jun 14, 2022
Merged

[5.3] Skip to amount to buy when region is selected #4442

merged 38 commits into from
Jun 14, 2022

Conversation

wachunei
Copy link
Member

@wachunei wachunei commented Jun 3, 2022 •
edited
Loading

> This PR is using base release/5.2.0. When that branch is merged to main, this should be updated to point to main as base.

This PR adds the skipping screen feature for on ramp aggregator.

  • When user has not previously selected a region, they will land on the Region screen (current behavior).
  • When user has previously selected a region, they will land on Amount to buy screen.
    • There is a small chance that the selected region changes to be unsupported, when that happens we redirect to Region screen and remove that selection.

metamaskbot and others added 30 commits May 16, 2022 18:44
@metamaskbot
5.2.0
76515a4
@Cal-L
Format changelog
3dad3f1
@wachunei @Cal-L
Fix check for empty tokens list (#4345)
5381c67
@Fatxx @Cal-L
Fix homepage scripts and env import (#4344)
a155f0d
@Cal-L
Make reveal SRP blur view dynamic (#4315)
5737d9c 
Co-authored-by: Gustavo Antunes <[email protected]>
@Cal-L
Update changelog
cd244bf
@rickycodes @cortisiko @Cal-L
Bugfix/fix subtitle mapping (#4349)
3becfde 
* fix subtitle mapping

* delete

* fix pt

* put setTimeout back

Co-authored-by: Curtis David <[email protected]>
@Cal-L
Update changelog
6c43e4b
@Cal-L
Update build numbers
047fc0c
@tommasini
[5.2.0][FIX] Alignment of check icon with option on select component (#…
13ab998 
…4363)
@tommasini
[5.2.0][FIX] Secret Recovery Phrase text alignment (#4369)
3ca296c
@tommasini
[5.2.0][FIX] M3 - Warning on legit address (#4376)
37442a4
@andreahaku
Fixes double tab opening when using metamask://dapp/ deep link sche…
bd64bd0 
…ma (#4383)
@wachunei
Fix order id retrieve in checkout (#4366)
494f328
@wachunei
Fix overriding network and account for orders being processed (#4364)
8a22652
@alaahd @wachunei
Error handling when no crypto currencies available on selected region (…
8cb3f1d 
…#4360)

Co-authored-by: Pedro Pablo Aste Kompen <[email protected]>
@VikChawla
bug patch - tx-details to display provider link and integrate the ord…
e809f0a 
…er object (#4359)
@wachunei
Refactor "Transaction" to "Order" when referring to fiat order (#4375)
ebccb9a 
* Refactor Transaction into Order for fiat orders

* Fix uppercase
@wachunei
Add On-Ramp Aggregator Analytics (#4362)
8727fc0
Bump build number
addd65a
[FIX] Add margin and check to AssetActionButton text (#4381)
f038c72
@andreahaku
Additional fixes for double tab opened with metamask://dapp/ schema (#…
fc971dc 
…4396)
@wachunei
Remove canOpenUrl from onramp linking (#4391)
3525dfe
@wachunei
Fix provider support string (#4387)
d324963
Bump build number
c18c22b
@wachunei
Fix wrong analytics event (#4408)
4aace57
@wachunei
Remove Harmony from supported networks (#4409)
ef3ac7b
@andreahaku
removes metamask://dapp/ schema support until stable on Android (#4412
7ba7892 
)
@andreahaku
Bump build number
58b78c9
Update CHANGELOG
e2e5480
@mobularay mobularay changed the title Skip to amount to buy when region is selected [5.3] Skip to amount to buy when region is selected Jun 7, 2022
Base automatically changed from release/5.2.0 to main June 7, 2022 23:00
@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2022

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@wachunei wachunei marked this pull request as ready for review June 8, 2022 13:41
@wachunei wachunei requested a review from a team as a code owner June 8, 2022 13:41
@mobularay mobularay added the release-5.3.0 Issue or pull request that will be included in release 5.3.0 label Jun 14, 2022
alaahd
alaahd approved these changes Jun 14, 2022
View reviewed changes
Copy link
Contributor

@alaahd alaahd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Cal-L
Copy link
Contributor

Cal-L commented Jun 14, 2022

Let's account for iPhones with notches on the bottom

image

1 similar comment
@Cal-L
Copy link
Contributor

Cal-L commented Jun 14, 2022

Let's account for iPhones with notches on the bottom

image

Cal-L
Cal-L approved these changes Jun 14, 2022
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from my comment, LGTM!

@wachunei wachunei merged commit a2b965c into main Jun 14, 2022
@wachunei wachunei deleted the feature/onramp-skip-screens branch June 14, 2022 23:36
@github-actions github-actions bot locked and limited conversation to collaborators Jun 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alaahd alaahd alaahd approved these changes

@Cal-L Cal-L Cal-L approved these changes

Assignees
No one assigned
Labels
release-5.3.0 Issue or pull request that will be included in release 5.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@wachunei @Cal-L @alaahd @mobularay @metamaskbot @Fatxx @rickycodes @tommasini @andreahaku @VikChawla