Fix warnings about non-virtual destructors for non-BMI classes with virtual methods #830
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to build warning-clean, and
-Wnon-virtual-dtor
can signal some serious potential errors. This PR fixes internal cases that trigger the warning.Changes
Formulation_Manager
and HydrofabricSubsetter: removevirtual
marking on member functions, since the classes don't have descendants that need virtual dispatchgeojson::FeatureVisitor
: add virtual destructorTesting
Notes
Checklist