Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings about non-virtual destructors for non-BMI classes with virtual methods #830

Merged
merged 3 commits into from
Jun 7, 2024

Conversation

PhilMiller
Copy link
Contributor

@PhilMiller PhilMiller commented Jun 7, 2024

We want to build warning-clean, and -Wnon-virtual-dtor can signal some serious potential errors. This PR fixes internal cases that trigger the warning.

Changes

  • Formulation_Manager and HydrofabricSubsetter: remove virtual marking on member functions, since the classes don't have descendants that need virtual dispatch
  • geojson::FeatureVisitor: add virtual destructor

Testing

  1. CI

Notes

  • BMI module class change will come in a separate PR, that changes both our copies and external git submodules together

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

@PhilMiller PhilMiller marked this pull request as ready for review June 7, 2024 20:17
@PhilMiller PhilMiller merged commit 6746a46 into NOAA-OWP:master Jun 7, 2024
19 checks passed
@PhilMiller PhilMiller deleted the PhilMiller/Wnon-virtual-dtor branch June 7, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants