Fix warnings about non-virtual destructors for non-BMI classes with virtual methods

include/geojson/FeatureVisitor.hpp

@@ -27,6 +27,8 @@ namespace geojson {
             virtual void visit(MultiLineStringFeature *feature) = 0;
             virtual void visit(MultiPolygonFeature *feature) = 0;
             virtual void visit(CollectionFeature* feature) = 0;
+
+            virtual ~FeatureVisitor() = default;
     };
 }
-#endif
+#endif

include/realizations/catchment/Formulation_Manager.hpp

@@ -47,7 +47,7 @@ namespace realization {
 
             ~Formulation_Manager() = default;
 
-            virtual void read(geojson::GeoJSON fabric, utils::StreamHandler output_stream) {
+            void read(geojson::GeoJSON fabric, utils::StreamHandler output_stream) {
                 //TODO seperate the parsing of configuration options like time
                 //and routing and other non feature specific tasks from this main function
                 //which has to iterate the entire hydrofabric.
@@ -180,46 +180,46 @@ namespace realization {
                 }
             }
 
-            virtual void add_formulation(std::shared_ptr<Catchment_Formulation> formulation) {
+            void add_formulation(std::shared_ptr<Catchment_Formulation> formulation) {
                 this->formulations.emplace(formulation->get_id(), formulation);
             }
 
-            virtual std::shared_ptr<Catchment_Formulation> get_formulation(std::string id) const {
+            std::shared_ptr<Catchment_Formulation> get_formulation(std::string id) const {
                 // TODO: Implement on-the-fly formulation creation using global parameters
                 return this->formulations.at(id);
             }
 
-            virtual std::shared_ptr<Catchment_Formulation> get_domain_formulation(long id) const {
+            std::shared_ptr<Catchment_Formulation> get_domain_formulation(long id) const {
                 return this->domain_formulations.at(id);
             }
 
-            virtual bool has_domain_formulation(int id) const {
+            bool has_domain_formulation(int id) const {
                 return this->domain_formulations.count( id ) > 0;
             }
 
-            virtual bool contains(std::string identifier) const {
+            bool contains(std::string identifier) const {
                 return this->formulations.count(identifier) > 0;
             }
 
             /**
              * @return The number of elements within the collection
              */
-            virtual int get_size() {
+            int get_size() {
                 return this->formulations.size();
             }
 
             /**
              * @return Whether or not the collection is empty
              */
-            virtual bool is_empty() {
+            bool is_empty() {
                 return this->formulations.empty();
             }
 
-            virtual typename std::map<std::string, std::shared_ptr<Catchment_Formulation>>::const_iterator begin() const {
+            typename std::map<std::string, std::shared_ptr<Catchment_Formulation>>::const_iterator begin() const {
                 return this->formulations.cbegin();
             }
 
-            virtual typename std::map<std::string, std::shared_ptr<Catchment_Formulation>>::const_iterator end() const {
+            typename std::map<std::string, std::shared_ptr<Catchment_Formulation>>::const_iterator end() const {
                 return this->formulations.cend();
             }
 

include/utilities/python/HydrofabricSubsetter.hpp

@@ -89,7 +89,7 @@ namespace utils {
                                                              py_cli(std::move(p.py_cli)),
                                                              partitionsConfigFile(std::move(p.partitionsConfigFile)) { }
 
-            virtual bool execSubdivision() {
+            bool execSubdivision() {
                 bool result;
                 try {
                     py::bool_ bool_result = py_cli.attr("divide_hydrofabric")();
@@ -102,7 +102,7 @@ namespace utils {
                 return result;
             }
 
-            virtual bool execSubdivision(int index) {
+            bool execSubdivision(int index) {
                 bool result;
                 try {
                     py::bool_ bool_result = py_cli.attr("divide_hydrofabric")(index);