buildPython*: redirect pre/postCheck to pre/postInstallCheck #379637
+22
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShamrockLee
force-pushed
the
build-python-precheck
branch
from
06891d7 to
2d76e4a
Compare
|
I rebased the feature branch onto the merge base of |
Goal: Unify the <pkg>.overrideAttrs interface for Python packages. Specify preInstallCheck/postInstallCheck as preCheck/postCheck if the latter is not specified. Use preInstallCheck/postInstallCheck in buildPython* setup hooks. When the checkPhase argument is specified, replace `runHook pre/postCheck` with `runHook pre/postInstallCheck` before assigning it to `installCheckPhase`.
Simplify implementation and ensure that pre/postInstallCheck only run once.
Simplify implementation and ensure that pre/postInstallCheck only run once.
ShamrockLee
force-pushed
the
build-python-precheck
branch
from
2d76e4a to
72b6cda
Compare
|
@ofborg build python3Packages.accelerate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR unifies the .overrideAttrs interface for Python packages regarding
preInstallCheckandpostInstallCheckin a compatible way.runHook pre/postCheckwithrunHook pre/postInstallCheckbefore assigning it toinstallCheckPhase.After this change,
pytestCheckPhasenow precedessphinxBuildPhaseif both invoked, and locale changes left bypytestCheckPhasecould trigger Sphinx's failure (sphinx-doc/sphinx#11739) (despite the topic of the linked issue, the error also occurs on Linux). As a result, this PR depends on a treewide locale cleanup:Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.