[Bug]: NuGetSdkResolver does not support being called in parallel #11443
Labels
Priority:2
Issues for the current backlog.
Product:MSBuildSDKResolver
The NuGet powered SDK resolver. Owned by MSBuild team
Type:Bug
Comments
jeffkl
added
Priority:2
18 tasks
jeffkl
added a commit
to NuGet/NuGet.Client
that referenced
this issue
Dec 17, 2021
The MSBuild SDK resolver APIs provide some state but it is not thread-safe. This results in the NuGet SDK resolver loading and parsing global.json N times in Visual Studio, once for solution load and once for every design time build. This change introduces a file cache based on path and last write time that is thread-safe. I also changed how global.json is parsed to help speed up the process. Fixes NuGet/Home#11443
jeffkl
added a commit
to NuGet/NuGet.Client
that referenced
this issue
Jan 3, 2022
The MSBuild SDK resolver APIs provide some state but it is not thread-safe. This results in the NuGet SDK resolver loading and parsing global.json N times in Visual Studio, once for solution load and once for every design time build. This change introduces a file cache based on path and last write time that is thread-safe. I also changed how global.json is parsed to help speed up the process. Fixes NuGet/Home#11450 Related to NuGet/Home#11443
8 tasks
jeffkl
added a commit
to NuGet/NuGet.Client
that referenced
this issue
Jan 12, 2022
The MSBuild SDK resolver APIs provide some state but it is not thread-safe. This results in the NuGet SDK resolver loading and parsing global.json N times in Visual Studio, once for solution load and once for every design time build. This change introduces a file cache based on path and last write time that is thread-safe. I also changed how global.json is parsed to help speed up the process. Fixes NuGet/Home#11450 Related to NuGet/Home#11443
jeffkl
added a commit
to NuGet/NuGet.Client
that referenced
this issue
Feb 2, 2022
The MSBuild SDK resolver APIs provide some state but it is not thread-safe. This results in the NuGet SDK resolver loading and parsing global.json N times in Visual Studio, once for solution load and once for every design time build. This change introduces a file cache based on path and last write time that is thread-safe. I also changed how global.json is parsed to help speed up the process. Fixes NuGet/Home#11450 Related to NuGet/Home#11443
jeffkl
added
the
Category:Quality Week
12 tasks
jeffkl
removed
the
Category:Quality Week
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
NuGet Product Used
MSBuild.exe
Product Version
All
Worked before?
No response
Impact
It's more difficult to complete my work
Repro Steps & Context
The MSBuild SDK resolution APIs can call SDK resolvers multiple times in parallel for each unique SDK. They can also call an SDK resolver for the same SDK if its part of two different builds (which happens in Visual Studio).
The NuGetSdkResolver should be updated to take into account that it can be called on different threads for the one or more SDKs.
Epic: #11441
Verbose Logs
No response
The text was updated successfully, but these errors were encountered: