Cache global.json in NuGet SDK resolver #4380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffkl
commented
Jan 3, 2022
src/NuGet.Core/Microsoft.Build.NuGetSdkResolver/GlobalJsonReader.cs
Outdated
Show resolved
Hide resolved
src/NuGet.Core/Microsoft.Build.NuGetSdkResolver/NuGetSdkResolver.cs
Outdated
Show resolved
Hide resolved
|
Note to self, do not merge until dev targets 17.2 |
18 tasks
erdembayar
reviewed
Jan 4, 2022
src/NuGet.Core/Microsoft.Build.NuGetSdkResolver/GlobalJsonReader.cs
Outdated
Show resolved
Hide resolved
nkolev92
approved these changes
Jan 5, 2022
erdembayar
approved these changes
Jan 5, 2022
zivkan
reviewed
Jan 5, 2022
src/NuGet.Core/Microsoft.Build.NuGetSdkResolver/GlobalJsonReader.cs
Outdated
Show resolved
Hide resolved
jeffkl
added
the
Merge next release
jeffkl
force-pushed
the
dev-jeffkl-global-json-reader-cache
branch
from
f5af52f to
1a86290
Compare
ghost
added
the
Status:No recent activity
|
This PR has been automatically marked as stale because it has no activity for 7 days. It will be closed if no further activity occurs within another 7 days of this comment. If it is closed, you may reopen it anytime when you're ready again, as long as you don't delete the branch. |
ghost
closed this
jeffkl
removed
Merge next release
|
@zivkan do you want to review this again before I merge? |
zivkan
reviewed
Feb 1, 2022
dtivel
approved these changes
Feb 2, 2022
src/NuGet.Core/Microsoft.Build.NuGetSdkResolver/GlobalJsonReader.cs
Outdated
Show resolved
Hide resolved
The MSBuild SDK resolver APIs provide some state but it is not thread-safe. This results in the NuGet SDK resolver loading and parsing global.json N times in Visual Studio, once for solution load and once for every design time build. This change introduces a file cache based on path and last write time that is thread-safe. I also changed how global.json is parsed to help speed up the process. Fixes NuGet/Home#11450 Related to NuGet/Home#11443
Add more logging and exception handling Address feedback
jeffkl
force-pushed
the
dev-jeffkl-global-json-reader-cache
branch
from
2992502 to
6ff3429
Compare
zivkan
approved these changes
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#11450
Regression? No
Description
The MSBuild SDK resolver APIs provide some state but it is not thread-safe. This results in the NuGet SDK resolver loading and parsing global.json N times in Visual Studio, once for solution load and once for every design time build.
This change introduces a file cache based on path and last write time that is thread-safe.
I also changed how global.json is parsed to help speed up the process.
Related to NuGet/Home#11443 and NuGet/Home#11441
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation