[DCR]: NuGet SDK resolver should cache global.json itself #11450
Assignees
Labels
Priority:2
Issues for the current backlog.
Product:MSBuildSDKResolver
The NuGet powered SDK resolver. Owned by MSBuild team
Type:DCR
Design Change Request
Milestone
Comments
jeffkl
added
Priority:2
18 tasks
jeffkl
added a commit
to NuGet/NuGet.Client
that referenced
this issue
Jan 3, 2022
The MSBuild SDK resolver APIs provide some state but it is not thread-safe. This results in the NuGet SDK resolver loading and parsing global.json N times in Visual Studio, once for solution load and once for every design time build. This change introduces a file cache based on path and last write time that is thread-safe. I also changed how global.json is parsed to help speed up the process. Fixes NuGet/Home#11450 Related to NuGet/Home#11443
8 tasks
jeffkl
added a commit
to NuGet/NuGet.Client
that referenced
this issue
Jan 12, 2022
The MSBuild SDK resolver APIs provide some state but it is not thread-safe. This results in the NuGet SDK resolver loading and parsing global.json N times in Visual Studio, once for solution load and once for every design time build. This change introduces a file cache based on path and last write time that is thread-safe. I also changed how global.json is parsed to help speed up the process. Fixes NuGet/Home#11450 Related to NuGet/Home#11443
jeffkl
added a commit
to NuGet/NuGet.Client
that referenced
this issue
Feb 2, 2022
The MSBuild SDK resolver APIs provide some state but it is not thread-safe. This results in the NuGet SDK resolver loading and parsing global.json N times in Visual Studio, once for solution load and once for every design time build. This change introduces a file cache based on path and last write time that is thread-safe. I also changed how global.json is parsed to help speed up the process. Fixes NuGet/Home#11450 Related to NuGet/Home#11443
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
NuGet Product(s) Affected
MSBuild.exe, dotnet.exe
Current Behavior
Currently the NuGet SDK resolver relies on the MSBuild SDK resolver APIs to save state. However, the state is not guaranteed to be thread-safe and so currently the NuGet SDK resolver is parsing global.json many times by Visual Studio. This is because the state is only set after a resolver completes and the cache key is a build submission. Visual Studio issues several design time builds will load global.json over and over.
Desired Behavior
The NuGet SDK resolver should have its own file cache that only loads a file once unless it has changed.
Additional Context
No response
The text was updated successfully, but these errors were encountered: