-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roll Pitch Yawrate Thrust (RPYrT) integration tests #14750
Conversation
@julianoes , a promise is a promise... |
The Fly Square Multicopter Missions failed, although I didn't touch that. The error seems gzserver related. Should I push it again to retrigger? |
@julianoes Fixed it, was a thrust issue. Seems good to merge. |
Yes if we can get everything passing reliably. |
Gazebo server is not being helpful today. It failed on a test I didn't change - and my test ran all successfully just before (my last change was removing a setting on .vscode/settings that I had. @dagar do you have a manual way to re-run it? EDIT: Re-running it fixed it, but this time Jenkins complained on a test I didn't do. Do I need to care? |
#!/usr/bin/env python2 | ||
#*************************************************************************** | ||
# | ||
# Copyright (c) 2015 PX4 Development Team. All rights reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Copyright (c) 2015 PX4 Development Team. All rights reserved. | |
# Copyright (c) 2020 PX4 Development Team. All rights reserved. |
#***************************************************************************/ | ||
|
||
# | ||
# @author Andreas Antener <[email protected]> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That should be you, or nothing.
integrationtests/python_src/px4_it/mavros/mavros_offboard_yawrate_test.py
Show resolved
Hide resolved
@julianoes not complete sure if my test is being run, although I think I added them to the jenkins CI. But here: http://ci.px4.io:8080/blue/organizations/jenkins/PX4_misc%2FFirmware-SITL_tests/detail/PR-14750/9/pipeline I don't see my test. Am I missing something? |
@dagar why does it not show up in CI? It's listed in the Jenkinsfiles... |
For PRs from forks for people outside the github org most CI services (maybe all?) use the configuration from the merge destination to prevent any potential abuse. |
@dagar , still no changes to Jenkins: http://ci.px4.io:8080/blue/organizations/jenkins/PX4_misc%2FFirmware-SITL_tests/detail/PR-14750/10/pipeline |
Fixed name. More naming fixes. Fixed thrust and ran locally with success. Removed defs in settings. Removed comma in settings. Updated author and license date.
Moved here #14796 |
Describe problem solved by this pull request
Added Roll Pitch Yawrate Thrust offboard control mode test.
Describe your solution
Added a new integration test based on the mavros_posix_offboared_attctl_test.py . Also added the file on the respective links on .ci and Makefile.