Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll Pitch Yawrate Thrust (RPYrT) integration tests #14750

Closed
wants to merge 1 commit into from
Closed

Roll Pitch Yawrate Thrust (RPYrT) integration tests #14750

wants to merge 1 commit into from

Conversation

Pedro-Roque
Copy link
Member

@Pedro-Roque Pedro-Roque commented Apr 24, 2020

Describe problem solved by this pull request
Added Roll Pitch Yawrate Thrust offboard control mode test.

Describe your solution
Added a new integration test based on the mavros_posix_offboared_attctl_test.py . Also added the file on the respective links on .ci and Makefile.

@Pedro-Roque
Copy link
Member Author

@julianoes , a promise is a promise...

@julianoes julianoes self-requested a review April 24, 2020 13:52
@Pedro-Roque Pedro-Roque changed the title Pr rpyrt test Roll Pitch Yawrate Thrust (RPYrT) integration tests Apr 24, 2020
@Pedro-Roque
Copy link
Member Author

The Fly Square Multicopter Missions failed, although I didn't touch that. The error seems gzserver related. Should I push it again to retrigger?

@Pedro-Roque
Copy link
Member Author

Pedro-Roque commented Apr 24, 2020

@julianoes Fixed it, was a thrust issue. Seems good to merge.
@dagar are we in time to add this on v1.11?

@dagar
Copy link
Member

dagar commented Apr 25, 2020

@dagar are we in time to add this on v1.11?

Yes if we can get everything passing reliably.

@Pedro-Roque
Copy link
Member Author

Pedro-Roque commented Apr 25, 2020

@dagar are we in time to add this on v1.11?

Yes if we can get everything passing reliably.

Gazebo server is not being helpful today. It failed on a test I didn't change - and my test ran all successfully just before (my last change was removing a setting on .vscode/settings that I had. @dagar do you have a manual way to re-run it?

EDIT: Re-running it fixed it, but this time Jenkins complained on a test I didn't do. Do I need to care?

#!/usr/bin/env python2
#***************************************************************************
#
# Copyright (c) 2015 PX4 Development Team. All rights reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Copyright (c) 2015 PX4 Development Team. All rights reserved.
# Copyright (c) 2020 PX4 Development Team. All rights reserved.

#***************************************************************************/

#
# @author Andreas Antener <[email protected]>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should be you, or nothing.

@Pedro-Roque
Copy link
Member Author

@julianoes not complete sure if my test is being run, although I think I added them to the jenkins CI. But here: http://ci.px4.io:8080/blue/organizations/jenkins/PX4_misc%2FFirmware-SITL_tests/detail/PR-14750/9/pipeline I don't see my test. Am I missing something?

@julianoes
Copy link
Contributor

@dagar why does it not show up in CI? It's listed in the Jenkinsfiles...

@dagar
Copy link
Member

dagar commented Apr 28, 2020

@dagar why does it not show up in CI? It's listed in the Jenkinsfiles...

For PRs from forks for people outside the github org most CI services (maybe all?) use the configuration from the merge destination to prevent any potential abuse.

@Pedro-Roque
Copy link
Member Author

Pedro-Roque commented Apr 28, 2020

@dagar why does it not show up in CI? It's listed in the Jenkinsfiles...

For PRs from forks for people outside the github org most CI services (maybe all?) use the configuration from the merge destination to prevent any potential abuse.

@dagar , still no changes to Jenkins: http://ci.px4.io:8080/blue/organizations/jenkins/PX4_misc%2FFirmware-SITL_tests/detail/PR-14750/10/pipeline

Fixed name.

More naming fixes.

Fixed thrust and ran locally with success.

Removed defs in settings.

Removed comma in settings.

Updated author and license date.
@Pedro-Roque
Copy link
Member Author

Moved here #14796

@Jaeyoung-Lim Jaeyoung-Lim added the Mode: Offboard Offboard mode control label Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants