-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Control Allocation: fixes in yaw saturation detection for vehicles with tilt-for-yaw #21994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TOL Tiltrotor) Signed-off-by: Silvan Fuhrer <[email protected]>
Signed-off-by: Silvan Fuhrer <[email protected]>
bkueng
reviewed
Aug 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense.
src/modules/control_allocator/ActuatorEffectiveness/ActuatorEffectivenessTiltrotorVTOL.cpp
Outdated
Show resolved
Hide resolved
src/modules/control_allocator/ActuatorEffectiveness/ActuatorEffectivenessTiltrotorVTOL.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Silvan Fuhrer <[email protected]>
bkueng
approved these changes
Aug 24, 2023
royratcliffe
pushed a commit
to royratcliffe/PX4-Autopilot
that referenced
this pull request
Sep 6, 2023
…th tilt-for-yaw (PX4#21994) * ActuatorEffectiveness: base yaw saturation on tilt actuator limits (VTOL Tiltrotor) * ActuatorEffectiveness: add custom yaw saturation for MC Tilt --------- Signed-off-by: Silvan Fuhrer <[email protected]>
antbre
pushed a commit
to BioMorphic-Intelligence-Lab/PX4-Autopilot
that referenced
this pull request
Sep 14, 2023
…th tilt-for-yaw (PX4#21994) * ActuatorEffectiveness: base yaw saturation on tilt actuator limits (VTOL Tiltrotor) * ActuatorEffectiveness: add custom yaw saturation for MC Tilt --------- Signed-off-by: Silvan Fuhrer <[email protected]>
ryrobotics
pushed a commit
to ryrobotics/PX4-Autopilot
that referenced
this pull request
Jan 2, 2024
…th tilt-for-yaw (PX4#21994) * ActuatorEffectiveness: base yaw saturation on tilt actuator limits (VTOL Tiltrotor) * ActuatorEffectiveness: add custom yaw saturation for MC Tilt --------- Signed-off-by: Silvan Fuhrer <[email protected]>
ryrobotics
pushed a commit
to ryrobotics/PX4-Autopilot
that referenced
this pull request
Jan 3, 2024
…th tilt-for-yaw (PX4#21994) * ActuatorEffectiveness: base yaw saturation on tilt actuator limits (VTOL Tiltrotor) * ActuatorEffectiveness: add custom yaw saturation for MC Tilt --------- Signed-off-by: Silvan Fuhrer <[email protected]>
ryrobotics
pushed a commit
to ryrobotics/PX4-Autopilot
that referenced
this pull request
Jan 4, 2024
…th tilt-for-yaw (PX4#21994) * ActuatorEffectiveness: base yaw saturation on tilt actuator limits (VTOL Tiltrotor) * ActuatorEffectiveness: add custom yaw saturation for MC Tilt --------- Signed-off-by: Silvan Fuhrer <[email protected]>
ryrobotics
pushed a commit
to ryrobotics/PX4-Autopilot
that referenced
this pull request
Jan 4, 2024
…th tilt-for-yaw (PX4#21994) * ActuatorEffectiveness: base yaw saturation on tilt actuator limits (VTOL Tiltrotor) * ActuatorEffectiveness: add custom yaw saturation for MC Tilt --------- Signed-off-by: Silvan Fuhrer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
VTOL Tiltrotors require a special yaw saturation detection. Simply looking at whether there is unallocated yaw torque leads to almost constant saturation reporting, as often one of the tilts is saturated (they usually can't tilt backwards). I patched this previously in #20518, where I simply declared the yaw saturated if the torque setpoint was saturated. Given that there is also a collective tilt this assumption is quite rough.
While flying a tricopter with sideways tiltable tail I further noticed that there the reported unallocated yaw was never 0, while the tilt servo clearly never reached saturation:
I didn't investigate further why the unallocated torque calculation is so wrong, but given that MC tilt vehicles would anyway have the same issues as VTOL tiltrotor if they have tilts that only tilt in one direction, it makes sense to me to customize the saturation handling anyway also for them.
Solution
Customize yaw saturation detection for VTOL tiltrotor and MC tilts. Taking the sign of the yaw effectiveness of the corresponding tilt into account, check if the tilt is at the min or max value and set the positive or negative saturation flag if all the tilts are saturated in this direction.
Changelog Entry
For release notes:
Alternatives
Extend it to have it generic for all axis with tilt actuation. I wonder though if we also should first remove the tilts from the effectiveness matrix and do custom allocation of them (something similar to what is done in the Helicopter allocation).
Test coverage
SITL tested (tiltrotor).