move geo and geo_lookup to PX4/ecl #9105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waiting on PX4/PX4-Matrix#61 |
dagar
force-pushed
the
pr-geo_ecl
branch
3 times, most recently
from
b11fed4 to
87cf620
Compare
|
Declination test failure. |
|
@priseborough could you take a quick pass to give the test some meaningful values? https://github.com/PX4/Firmware/blob/master/src/systemcmds/tests/test_autodeclination.cpp#L26-L31 |
dagar
force-pushed
the
pr-geo_ecl
branch
2 times, most recently
from
19f5b36 to
6958016
Compare
|
Declination test updated. |
|
OK, will do so today |
priseborough
force-pushed
the
pr-geo_ecl
branch
from
5bfe4e5 to
545db57
Compare
|
Updating clang-tidy in tests only to allow the huge function. |
priseborough
previously approved these changes
Mar 26, 2018
|
ECL side merged and submodule updated. Merge as soon as Firmware CI checks out. |
|
The ECL update also brings in "EKF: Reduce effect of GPS noise when using other aiding sources" (PX4/PX4-ECL#403). @priseborough please advise if you'd like to bring that in separately with dedicated testing before this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are both dependencies of the ECL.
ECL side - PX4/PX4-ECL#410