Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1665 Mutation joinPublicOrganization not complatible with talawa-api #1205

Merged
merged 6 commits into from
Mar 25, 2023

Conversation

Ayush0Chaudhary
Copy link
Contributor

@Ayush0Chaudhary Ayush0Chaudhary commented Mar 19, 2023

What kind of change does this PR introduce?
It contains a new resolver that is required for mobile app to properly

Issue Number:

Fixes PalisadoesFoundation/talawa#1665

Did you add tests for your changes?
no

Snapshots/Videos:

signupPR.mp4

If relevant, did you update the documentation?

Summary
It contains a resolver that return a list of orgs user have joined

Does this PR introduce a breaking change?
no

Other information
no

Have you read the contributing guide?
yes

@Ayush0Chaudhary Ayush0Chaudhary changed the title Fixes ##1665 Mutation joinPublicOrganization not complatible with talawa-api Fixes #1665 Mutation joinPublicOrganization not complatible with talawa-api Mar 19, 2023
@Ayush0Chaudhary
Copy link
Contributor Author

Ayush0Chaudhary commented Mar 19, 2023

@palisadoes
@xoldyckk

@xoldd
Copy link
Contributor

xoldd commented Mar 20, 2023

@Ayush0Chaudhary Let's not talk in the PR space. Made a new discussions tab:- https://github.com/PalisadoesFoundation/talawa-api/discussions.

Delete your messages from here.

@Ayush0Chaudhary
Copy link
Contributor Author

@palisadoes
Copy link
Contributor

Please fix the errors

@Ayush0Chaudhary
Copy link
Contributor Author

Ayush0Chaudhary commented Mar 25, 2023

@xoldyckk, it is returning the complete org list now. 🥳
I understood what you were trying to say

Please merge my 2 line PR its important for mobile app to run. 🫡
@palisadoes @jordan-barrett-jm

@codecov
Copy link

codecov bot commented Mar 25, 2023

Codecov Report

Merging #1205 (e7319ad) into develop (29aee7a) will increase coverage by 2.21%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #1205      +/-   ##
===========================================
+ Coverage    96.40%   98.61%   +2.21%     
===========================================
  Files          172      176       +4     
  Lines        10725    11056     +331     
  Branches       778      836      +58     
===========================================
+ Hits         10339    10903     +564     
+ Misses         386      153     -233     
Impacted Files Coverage Δ
src/resolvers/Mutation/joinPublicOrganization.ts 100.00% <100.00%> (ø)

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@palisadoes palisadoes merged commit bfe4aa4 into PalisadoesFoundation:develop Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG REPORT] Mutation joinPublicOrganization not complatible with talawa-api
3 participants