Fixes ##1665 Mutation joinPublicOrganization not complatible with tal… #1683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…complatible with talawa-api
|
Please don't merge it before the API PR is merged |
|
|
This is the PR. |
noman2002
requested changes
Mar 20, 2023
|
Please fix the failing tests |
|
@palisadoes @noman2002 No need of this PR. Closing this PR (First time using github's Close with Comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
The signup didn't used to work, the talawa-api schema changed, so the app was running on deprecated schema, I upgraded the flow of request the app make in order to signup
Issue Number:
Fixes #1665
Did you add tests for your changes?
No yet
Snapshots/Videos:
signupPR.mp4
If relevant, did you update the documentation?
no
Summary
User caan sign up now
Does this PR introduce a breaking change?
yes, maybe
Other information
I also changed the name of function talawaerrorwidget and talawaerrordialog as it indicated that they were meant to show error only
Have you read the contributing guide?
yes