Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG REPORT] Mutation joinPublicOrganization not complatible with talawa-api #1665

Closed
Ayush0Chaudhary opened this issue Mar 14, 2023 · 9 comments · Fixed by PalisadoesFoundation/talawa-api#1205
Assignees
Labels
bug Something isn't working

Comments

@Ayush0Chaudhary
Copy link
Contributor

Describe the bug
This is the Error we face when we try to Signup user for the first time

To Reproduce
Steps to reproduce the behavior:

1.Try to Signup
2.
3.
4.

Expected behavior
Should be able to join org

Actual behavior
not allowing

Additional details
Failing mutation
```
mutation {
joinPublicOrganization(organizationId: "$orgId") {
joinedOrganizations{
_id
name
image
description
isPublic
creator{
_id
firstName
lastName
image
}

         }
     }
}
```

Api-error-log
Cannot return null for non-nullable field Organization.name. {"locations":[{"line":8,"column":7}],"path":["joinPublicOrganization","joinedOrganizations",0,"name"],"extensions":{"code":"INTERNAL_SERVER_ERROR","exception":{"stacktrace":["/home/panda/talawa-api/node_modules/graphql/execution/execute.js:559"," throw new Error("Cannot return null for non-nullable field ".concat(info.parentType.name, ".").concat(info.fieldName, "."));"," ^","","Error: Cannot return null for non-nullable field Organization.name."," at completeValue (/home/panda/talawa-api/node_modules/graphql/execution/execute.js:559:13)"," at resolveField

Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship #359

@Ayush0Chaudhary Ayush0Chaudhary added the bug Something isn't working label Mar 14, 2023
@github-actions github-actions bot added the unapproved Unapproved, needs to be triaged label Mar 14, 2023
@Ayush0Chaudhary
Copy link
Contributor Author

This is an urgent issue as it will not let new contributors to enter the app

@Ayush0Chaudhary
Copy link
Contributor Author

This prevent a newcomer to enter the app until and unless he use some tricks like
first signing up and catching the error, then use same creds to loggin, and enter the org

@palisadoes palisadoes removed the unapproved Unapproved, needs to be triaged label Mar 14, 2023
@Ayush0Chaudhary
Copy link
Contributor Author

@noman2002 @palisadoes @xoldyckk
The error is resolved, but the PR on talawa-api needs to merged first before the PR on this repo

I am raising the PRs now.

@Ayush0Chaudhary
Copy link
Contributor Author

Now new contributor will be able to at least start the app. 🥳

Ayush0Chaudhary added a commit to Ayush0Chaudhary/talawa that referenced this issue Mar 19, 2023
@palisadoes
Copy link
Contributor

Which PR is that?

@Ayush0Chaudhary
Copy link
Contributor Author

PR on talawa-api require test, Can I publish the PR without test, new to writing test in mongoose, Can I write test later.?

@Ayush0Chaudhary
Copy link
Contributor Author

Which PR is that?
PalisadoesFoundation/talawa-api#1205

@palisadoes
Copy link
Contributor

PR on talawa-api require test, Can I publish the PR without test, new to writing test in mongoose, Can I write test later.?

You'll need to write the tests now, or else there is no guarantee they will be completed.

@Ayush0Chaudhary
Copy link
Contributor Author

Okay I'll write them by tonight 🫡

Ayush0Chaudhary added a commit to Ayush0Chaudhary/talawa that referenced this issue Mar 29, 2023
…omplatible with talawa-api (PalisadoesFoundation#1205)

* Fixes PalisadoesFoundation#1167 Wrong steps in Installation.md

* Update INSTALLATION.md

* Fixes #PalisadoesFoundation#1665 Mutation joinPublicOrganization not complatible with talawa-api

* Fixes PalisadoesFoundation#1665 Mutation joinPublicOrganization not complatible with talawa-api

* Added tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants