Fallback to English translations in e2e tests #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efalkner
reviewed
Apr 27, 2020
Patrick-Erichsen
approved these changes
Apr 28, 2020
tstirrat
added a commit
that referenced
this pull request
Apr 30, 2020
* develop: (22 commits) Translation refresh (#708) updated issue template (#729) Set up location after skiping the steps (#721) App shows green icon when tracking is inactive (#722) Fix postinstall script on Windows (#720) Fix isVersionGreater and add tests (#726) update the upgrade version to 1.0.0, to match what is in the master branch and avoid mistaken forced upgrades. (#723) 1.0.1 (#715) Put GPS filter behind dev flag (#714) Fix headline1 text cutoff (#712) Put auto sub behind dev flags (#711) remove default news url from News.js constructor (#704) Fix i18n placeholder for authorities (#709) Remove react-native-maps (#695) Fix e2e authority auto sub tests (#706) Fallback to English translations in e2e tests (#697) Add ja and fil languages (#700) Add a script to pull translations from lokalise (#641) Really really push to lokalise (#699) Run lokalize push on merge into develop (#698) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes e2e when there are test on new strings. It will fall back to English for any missing keys, which matches the i18n lib's functionality
Linked issues:
Screenshots:
How to test
e2e should pass