Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e authority auto sub tests #706

Merged
merged 1 commit into from
Apr 28, 2020
Merged

Fix e2e authority auto sub tests #706

merged 1 commit into from
Apr 28, 2020

Conversation

Patrick-Erichsen
Copy link
Contributor

Signed-off-by: Patrick Erichsen [email protected]

Description

Fixes a broken e2e test that wasn't caught before merging due to the language string PR that wasn't merged until afterward.

How to test

Verify that all CI tests pass.

Signed-off-by: Patrick Erichsen <[email protected]>
@kenpugsley kenpugsley self-requested a review April 28, 2020 05:24
Copy link
Collaborator

@kenpugsley kenpugsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! Looks good.

@Patrick-Erichsen Patrick-Erichsen merged commit 0540716 into Path-Check:develop Apr 28, 2020
@Patrick-Erichsen Patrick-Erichsen deleted the pe-fix-auto-sub-e2e branch April 28, 2020 13:49
tstirrat added a commit that referenced this pull request Apr 30, 2020
* develop: (22 commits)
  Translation refresh (#708)
  updated issue template (#729)
  Set up location after skiping the steps (#721)
  App shows green icon when tracking is inactive (#722)
  Fix postinstall script on Windows (#720)
  Fix isVersionGreater and add tests (#726)
  update the upgrade version to 1.0.0, to match what is in the master branch and avoid mistaken forced upgrades. (#723)
  1.0.1 (#715)
  Put GPS filter behind dev flag (#714)
  Fix headline1 text cutoff (#712)
  Put auto sub behind dev flags (#711)
  remove default news url from News.js constructor (#704)
  Fix i18n placeholder for authorities (#709)
  Remove react-native-maps (#695)
  Fix e2e authority auto sub tests (#706)
  Fallback to English translations in e2e tests (#697)
  Add ja and fil languages (#700)
  Add a script to pull translations from lokalise (#641)
  Really really push to lokalise (#699)
  Run lokalize push on merge into develop (#698)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants