Add a script to pull translations from lokalise #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tstirrat
commented
Apr 23, 2020
tstirrat
added
the
translation
|
@tstirrat This is really good! Once the conflicts are fixed, is this ready to be merged? |
tstirrat
added
the
Do Not Merge (yet)
* develop: (24 commits) Translation to Brazilian Portuguese (#614) Italian language updates (#626) Remove authority selection from onboarding (#679) v1.0.0 (#669) Hide unintented "What does this mean?" message (#668) BUGFIX: Add authority wasn't immediate (#667) Polish the EULA (#666) Add in a 6 hour time period between notifications (#665) Add an EULA to the onboarding process (#638) change to rawcdn for the versions.yaml file (#662) Change naming in yaml, change yaml link (#661) Add version check service (#653) Add healthcare selection to onboarding flow (#657) Add yaml file for version checking (#658) Fix languages specific for history page (#628) Lokalise: Translations update (ht) (#655) Temporarily filter out extra languages in release mode (#654) Suggest screenshots and fixed issues in PR template (#637) Fix settings locale override storage (#649) Disable google import on release builds (#651) ...
|
Language updates look correct as far as I can tell - could you give a little more context as to what Lokalise is doing in the pull script though? I'm assuming it's something we would run in CI, but I don't see it being added to any of our workflows here? |
* develop: Fix "plural" keys, add i18n checks for new PRs (#648) Auto add authorities (#587) Clean up more eslint issues (#678) Make nav back arrow color theme aware (#686) yarn run-ios now runs pod install (#681) Fix settings icon on iOS 12, replace with new icon (#687) Feature/creole tests (#690) Fix formatting EULAs (#671) [i18n] Don't translate terms_of_use_url (#642) Fix background to run to edge of screen on iOS (#682)
efalkner
approved these changes
Apr 28, 2020
tstirrat
added a commit
that referenced
this pull request
Apr 30, 2020
* develop: (22 commits) Translation refresh (#708) updated issue template (#729) Set up location after skiping the steps (#721) App shows green icon when tracking is inactive (#722) Fix postinstall script on Windows (#720) Fix isVersionGreater and add tests (#726) update the upgrade version to 1.0.0, to match what is in the master branch and avoid mistaken forced upgrades. (#723) 1.0.1 (#715) Put GPS filter behind dev flag (#714) Fix headline1 text cutoff (#712) Put auto sub behind dev flags (#711) remove default news url from News.js constructor (#704) Fix i18n placeholder for authorities (#709) Remove react-native-maps (#695) Fix e2e authority auto sub tests (#706) Fallback to English translations in e2e tests (#697) Add ja and fil languages (#700) Add a script to pull translations from lokalise (#641) Really really push to lokalise (#699) Run lokalize push on merge into develop (#698) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
yarn i18n:pullwhich will pull down all relevant translations.There shouldn't be any en.json changes in subsequent runs, but this one syncs up lokalise with the local files...
Dependencies:
export_paraplural issues (Fix incorrect "plural" keys, add key checks for new PRs #648)How to test
Verify language updates look correct