Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(graphCardHelpers): issues/317 yAxisTickFormatFallback #323

Merged
merged 1 commit into from
Jun 17, 2020

Conversation

cdcabrera
Copy link
Member

What's included

  • fix(graphCardHelpers): issues/317 yAxisTickFormatFallback
    • graphCardHelpers, apply abbreviation fallback

Notes

  • Applies a fallback method for y axis tick abbreviations for Firefox, Linux machines

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test

Example

...

Updates issue/story

#317
relates #296

cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Jun 17, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2020

Codecov Report

Merging #323 into ci will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##               ci     #323      +/-   ##
==========================================
+ Coverage   92.41%   92.52%   +0.11%     
==========================================
  Files          56       56              
  Lines        1305     1325      +20     
  Branches      305      310       +5     
==========================================
+ Hits         1206     1226      +20     
  Misses         84       84              
  Partials       15       15              
Impacted Files Coverage Δ
src/components/graphCard/graphCardHelpers.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 577adb9...d1fe4d6. Read the comment docs.

@cdcabrera cdcabrera merged commit 475ee20 into RedHatInsights:ci Jun 17, 2020
cdcabrera added a commit that referenced this pull request Jun 25, 2020
* graphCardHelpers, apply abbreviation fallback
cdcabrera added a commit that referenced this pull request Jul 13, 2020
* graphCardHelpers, apply abbreviation fallback
cdcabrera added a commit that referenced this pull request Jul 28, 2020
* graphCardHelpers, apply abbreviation fallback
cdcabrera added a commit that referenced this pull request Jul 30, 2020
* graphCardHelpers, apply abbreviation fallback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants