Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise warning on using Money.default_currency #882

Merged
merged 1 commit into from
Jul 14, 2019
Merged

Raise warning on using Money.default_currency #882

merged 1 commit into from
Jul 14, 2019

Conversation

antstorm
Copy link
Contributor

Money.default_currency will change to nil in v7. Raising a warning to inform everyone ahead of time and prevent potential issues

@coveralls
Copy link

coveralls commented Jul 14, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling d4372da on antstorm:default-currency-warning into 4293055 on RubyMoney:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 99.964% when pulling d4372da on antstorm:default-currency-warning into 4293055 on RubyMoney:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 99.964% when pulling d4372da on antstorm:default-currency-warning into 4293055 on RubyMoney:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 99.964% when pulling d4372da on antstorm:default-currency-warning into 4293055 on RubyMoney:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 99.964% when pulling d4372da on antstorm:default-currency-warning into 4293055 on RubyMoney:master.

@antstorm antstorm merged commit 6be1cfb into RubyMoney:master Jul 14, 2019
@antstorm antstorm deleted the default-currency-warning branch July 14, 2019 12:47
@smudge smudge mentioned this pull request Dec 6, 2019
Merged
@kennyadsl kennyadsl mentioned this pull request Dec 10, 2019
Merged
3 tasks
jrafanie added a commit to jrafanie/money that referenced this pull request Jan 2, 2020
@jrafanie
Warn about changing defaults with both the old (current) and new values.
22d3565 
Currency:  from USD to nil
Rounding:  from ROUND_HALF_EVEN to ROUND_HALF_UP

The warnings were added in RubyMoney#882 and RubyMoney#883 and refined in RubyMoney#902.
@jrafanie jrafanie mentioned this pull request Jan 2, 2020
Merged
antstorm pushed a commit that referenced this pull request Jan 2, 2020
@jrafanie @antstorm
Include old (current) values in the deprecation warnings (#906)
b25f5a2 
Currency:  from USD to nil
Rounding:  from ROUND_HALF_EVEN to ROUND_HALF_UP

The warnings were added in #882 and #883 and refined in #902.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antstorm @coveralls