Raise warning on using default Money.rounding_mode #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@antstorm - just curious, why change the default |
|
@wholien the default rounding mode is |
kennyadsl
added a commit
to nebulab/solidus
that referenced
this pull request
Dec 10, 2019
This is the current default value, but it will change in the Money gem in some future release (v7). People can start adhering to that value by setting Money.rounding_mode = BigDecimal::ROUND_HALF_UP in their own application. For now, this is what we used so far and we should not change it for existing applications. Ref: RubyMoney/money#883
3 tasks
|
@antstorm appreciate the explanation. |
jrafanie
added a commit
to jrafanie/money
that referenced
this pull request
Jan 2, 2020
Currency: from USD to nil Rounding: from ROUND_HALF_EVEN to ROUND_HALF_UP The warnings were added in RubyMoney#882 and RubyMoney#883 and refined in RubyMoney#902.
antstorm
pushed a commit
that referenced
this pull request
Jan 2, 2020
jiz4oh
pushed a commit
to castlery/solidus
that referenced
this pull request
Apr 15, 2022
This is the current default value, but it will change in the Money gem in some future release (v7). People can start adhering to that value by setting Money.rounding_mode = BigDecimal::ROUND_HALF_UP in their own application. For now, this is what we used so far and we should not change it for existing applications. Ref: RubyMoney/money#883
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default
Money.rounding_modewill change toROUND_HALF_UPin v7. Warning everyone ahead of time to minimise potential impact