Fix Money gem deprecations #3453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the current default value, but it will change in the Money gem in some future release (v7). People can start adhering to that value by setting Money.rounding_mode = BigDecimal::ROUND_HALF_UP in their own application. For now, this is what we used so far and we should not change it for existing applications. Ref: RubyMoney/money#883
Not setting a default currency is deprecated and the default will be nil in some future version (probably v7). We are setting the default using the Spree::Config.currency setting that we already have.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a couple of deprecation warnings we are receiving from Money gem.
Money.rounding_mode deprecation, which emits:
Money.default_currency deprecation, which emits:
Checklist:
[ ] I have added tests to cover this change (if needed)[ ] I have attached screenshots to this PR for visual changes (if needed)