-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch Hydrogen test runner from Jest to Vitest #670
Comments
Adding Vitest for hydrogen-ui, so we're on that from the start. As we migrate components over, we can translate the existing Jest tests to Vitest. |
Hey! I see that all tests in |
@mrkldshv I don't think so, just the time and bandwidth to do it. |
Right, I see. Can I start working on this? |
@mrkldshv Let's hold off for a little bit - there's still some discussion about the future of the hydrogen-ui package that we need to figure out. I'll respond in this thread with more details once we have made the decision. Thanks for your enthusiasm! One thing we could try to figure out now / very soon is if we could set it up in a way to slowly migrate the existing tests from Jest to Vitest in-place. Maybe what we could do is create new Vitest files with a different extension like With the goal being that we don't have to do all the tests as once, and instead migrate them over in smaller chunks. Then when it's done we can rename the Thoughts? Other ideas? |
Thanks for reply! I was thinking to start migrating tests gradually, and having separate file extension sounds like a good idea. From what I understand we need to wait for the decision concerning |
I'll see if it's useful / possible to setup that situation with Vitest in the existing repo, and if so, we can at least get started there and migrate tests, regardless of the outcome about hydrogen-ui. |
That'd be great! Thanks! |
To provide an update here, as promised above
We're full-speed ahead on hydrogen-ui now 🙂 |
No description provided.
The text was updated successfully, but these errors were encountered: