Use lang directive #1028
Merged
Use lang directive #1028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frehner
reviewed
Mar 31, 2022
…ase in the provider
michenly
force-pushed
the
use-lang-directive
branch
from
31cb73e to
7e74d4e
Compare
michenly
force-pushed
the
use-lang-directive
branch
from
d6b2034 to
67ecff9
Compare
michenly
force-pushed
the
use-lang-directive
branch
from
67ecff9 to
0ff34df
Compare
This comment has been minimized.
This comment has been minimized.
michenly
force-pushed
the
use-lang-directive
branch
from
fdfcc66 to
661ce0f
Compare
frehner
reviewed
Apr 1, 2022
packages/hydrogen/src/components/LocalizationProvider/LocalizationQuery.graphql
Outdated
Show resolved
Hide resolved
packages/hydrogen/src/components/LocalizationProvider/LocalizationQuery.ts
Outdated
Show resolved
Hide resolved
blittle
reviewed
Apr 4, 2022
.changeset/hungry-scissors-cross.md
Outdated
| 'test-server-components': patch | ||
| --- | ||
|
|
||
| Starting from SF API version `2022-04`, the prefer way to request for translatable resources is using the `@inContext` directive. See [API docs](https://shopify.dev/api/examples/multiple-languages#retrieve-translations-with-the-storefront-api) on how to do this and which resources have translatable properties. |
There was a problem hiding this comment.
It seems a bit unfortunate to me that this can't be more automatic, but has to be so manual.
jplhomer
reviewed
Apr 4, 2022
michenly
force-pushed
the
use-lang-directive
branch
3 times, most recently
from
571ea36 to
ba6bdc6
Compare
michenly
force-pushed
the
use-lang-directive
branch
from
e76f326 to
a6bfbe0
Compare
jplhomer
approved these changes
Apr 5, 2022
vlucas
approved these changes
Apr 5, 2022
blittle
pushed a commit
that referenced
this pull request
Apr 11, 2022
* remove lang code from shop query's header * add lang directive to localization provider & add languageCode to useShop * add lang directive to all the query that support lang in demo store * fix test * update shopify provider type and conver locale & lang code to upper case in the provider * fix test * update doc * add changeset * update test * edit docs * Remove LocalizationQuery.graphql and its type * doc fix
blittle
added a commit
that referenced
this pull request
Apr 11, 2022
* v1.x-2022-07: [Hydrogen docs]: Analytics (#962) Analytics (#890) Allow line breaks inside script tags (#1061) Fix encoding of CSS Modules to solve hydration errors (#1062) [Hydrogen docs]: Update guidance on troubleshooting third-party dependencies (#1055) Update Vite RSC Plugin (#1054) Fix link prefetch (#1059) Initial devTools component (#998) Support sub request cache control header `stale-while-revalidate` everywhere (#1049) Fix cookie parsing (#1046) Update 3-external-images-with-a-custom-loader.example.tsx (#1045) Restore scroll position on browser navigation (#1047) Remove old changeset to unblock release (#1042) [ci] release v1.x-2022-07 (#1019) Update to Vite 2.9 (#1039) Use lang directive (#1028)
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Switch to using language directive instead of header to query for lang specific content.
https://shopify.dev/api/examples/multiple-languages#translatable-resources
Additional context
Before submitting the PR, please make sure you do the following:
fixes #123)yarn changeset addif this PR cause a version bump based on Keep a Changelog and adheres to Semantic Versioning