Support sub request cache control header stale-while-revalidate everywhere
#1049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
jplhomer
requested changes
Apr 6, 2022
wizardlyhel
changed the title
stale-while-revalidate everywhere
mcvinci
reviewed
Apr 7, 2022
jplhomer
approved these changes
Apr 7, 2022
| @@ -17,7 +17,7 @@ export class InMemoryCache { | |||
| } | |||
|
|
|||
| put(request: Request, response: Response) { | |||
| logCacheApiStatus('PUT', request.url); | |||
| logCacheApiStatus('PUT-dev', request.url); | |||
There was a problem hiding this comment.
I think we'll be using this in production soon Shopify/hydrogen#977 do we need the -dev suffixes? Not a blocker — we can address in a future PR.
There was a problem hiding this comment.
The reason I put the -dev suffixes is because this in-memory cache can only be turned on if devCache is turn on. I want it to be obvious that it is a cache for development purpose and not for production purpose.
There was a problem hiding this comment.
Let's leave it for now and address in that future PR
Co-authored-by: Michelle Vinci <[email protected]>
blittle
added a commit
that referenced
this pull request
Apr 11, 2022
* v1.x-2022-07: [Hydrogen docs]: Analytics (#962) Analytics (#890) Allow line breaks inside script tags (#1061) Fix encoding of CSS Modules to solve hydration errors (#1062) [Hydrogen docs]: Update guidance on troubleshooting third-party dependencies (#1055) Update Vite RSC Plugin (#1054) Fix link prefetch (#1059) Initial devTools component (#998) Support sub request cache control header `stale-while-revalidate` everywhere (#1049) Fix cookie parsing (#1046) Update 3-external-images-with-a-custom-loader.example.tsx (#1045) Restore scroll position on browser navigation (#1047) Remove old changeset to unblock release (#1042) [ci] release v1.x-2022-07 (#1019) Update to Vite 2.9 (#1039) Use lang directive (#1028)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: https://github.com/Shopify/custom-storefronts/issues/175
Description
This is a workaround for supporting
stale-while-revalidatecache controlon CloudflareeverywhereHow to test on Cloudflare
You must have:
worker.devthat Cloudflare gives you)Once you have satisfy the above requirements, you can deploy your app with
setLoggerOptions({showCacheApiStatus: true})andwrangler tail -f prettyto see the cache api logs.Before submitting the PR, please make sure you do the following:
fixes #123)yarn changeset addif this PR cause a version bump based on Keep a Changelog and adheres to Semantic Versioning