🐛 Fixed cardWidth being lost on 2.0 imports #10068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no issue - When importing Ghost 2.0 blogs into 2.0 blogs... - The Koenig image card would lose it's cardWidth setting, - because it'd be overridden by the imageStyle setting, which was null - The importer previous _only_ kept the width if importing 1.0 blogs
kirrg001
reviewed
Oct 25, 2018
kirrg001
approved these changes
Oct 25, 2018
allouis
added a commit
that referenced
this pull request
Oct 30, 2018
* master: Version bump to 2.4.0 Updated Ghost-Admin to 2.4.0 Handled error from express-session middleware (#10084) Removed user_id constraint when upserting session (#10085) Added Node v10 Support (#10058) Removed logic for migration script (2.0/6-replace-fixture-posts.js) (#10081) Fixed sanitization issue in subscribers Parsed nconf env values (#10077) 🐛 Fixed missing filename when exporting subscribers csv 🐛 Fixed pagination for subscribers 🐛 Fixed cardWidth being lost on 2.0 imports (#10068) Corrected 'Content-Length' header by using Buffer.byteLength (#10055) Fixed mail api usage of the notifcations api Refactored request unit tests to return promises (#10045) Refactored spam prevention tests to use promises (#10036) Enforced unix line endings (#9871)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Came across this whilst building our html->to->mobiledoc migration tooling. I'm correctly setting
cardWidthin the parser plugins, and it's correctly being output in the mobiledoc, but Ghost import is throwing the cardWidth away.no issue