Skip to content

Commit

Permalink
apache#2450 fix spelling error and better variable name
Browse files Browse the repository at this point in the history
  • Loading branch information
ryan02.yang committed Mar 12, 2024
1 parent c7767ed commit 9e393d8
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -307,14 +307,14 @@ void testAlterTableRenameColumn() {
checkTableColumns(tableName, simpleTableColumns, getTableInfo(tableName));

String oldColumnName = "age";
String newColumnName = "newAge";
String newColumnName = "new_age";

sql(
String.format(
"ALTER TABLE %S RENAME COLUMNS %S TO %S", tableName, oldColumnName, newColumnName));
ArrayList<SparkColumnInfo> renameColumns = new ArrayList<>(simpleTableColumns);
renameColumns.remove(SparkColumnInfo.of("age", DataTypes.IntegerType, null));
renameColumns.add(SparkColumnInfo.of("newAge", DataTypes.IntegerType, null));
renameColumns.remove(SparkColumnInfo.of(oldColumnName, DataTypes.IntegerType, null));
renameColumns.add(SparkColumnInfo.of(newColumnName, DataTypes.IntegerType, null));
checkTableColumns(tableName, renameColumns, getTableInfo(tableName));
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ void testTransformRenameColumn() {
com.datastrato.gravitino.rel.TableChange.RenameColumn gravitinoRenameColumn =
(com.datastrato.gravitino.rel.TableChange.RenameColumn) gravitinoChange;

Assertions.assertEquals(oldFiledsName, gravitinoRenameCeolumn.getFieldName());
Assertions.assertEquals(oldFiledsName, gravitinoRenameColumn.getFieldName());
Assertions.assertEquals(newFiledName, gravitinoRenameColumn.getNewName());
}

Expand Down

0 comments on commit 9e393d8

Please sign in to comment.