Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add schools #610

Closed
wants to merge 50 commits into from
Closed

Add schools #610

wants to merge 50 commits into from

Conversation

Rotheem
Copy link
Member

@Rotheem Rotheem commented Oct 27, 2024

Description

Please explain the changes you made here.

Checklist

  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the documentation, if necessary

@gitguardian GitGuardian
Copy link

gitguardian bot commented Nov 18, 2024 •
edited
Loading

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
7298663 Triggered RSA Private Key 8196515 .env.test View secret
7298664 Triggered Generic Password 8196515 tests/test_auth.py View secret
7298668 Triggered Generic High Entropy Secret 8196515 .env.test View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@Rotheem Rotheem force-pushed the schools branch 2 times, most recently from 455a01b to 2d30254 Compare November 19, 2024 03:29
@codecov Codecov
Copy link

codecov bot commented Nov 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 83.51648% with 30 lines in your changes missing coverage. Please review.

Project coverage is 81.13%. Comparing base (5f08b6d) to head (d09696a).

Files with missing lines Patch % Lines
app/core/schools/endpoints_schools.py 80.39% 10 Missing ⚠️
app/core/users/endpoints_users.py 68.96% 9 Missing ⚠️
app/core/schools/cruds_schools.py 82.75% 5 Missing ⚠️
app/utils/initialization.py 72.72% 3 Missing ⚠️
app/app.py 84.61% 2 Missing ⚠️
app/core/schools/schools_type.py 83.33% 1 Missing ⚠️
Additional details and impacted files 
@@                    Coverage Diff                     @@
##           account-type-refactoring     #610    +/-   ##
==========================================================
  Coverage                     81.13%   81.13%            
==========================================================
  Files                           128      131     +3     
  Lines                         10003    10169   +166     
==========================================================
+ Hits                           8116     8251   +135     
- Misses                         1887     1918    +31

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@armanddidierjean armanddidierjean marked this pull request as draft November 21, 2024 09:18
@armanddidierjean armanddidierjean changed the base branch from main to account-type-refactoring November 21, 2024 09:19
@Rotheem Rotheem force-pushed the account-type-refactoring branch from 9227c3b to 5f08b6d Compare November 27, 2024 02:23
@Rotheem Rotheem force-pushed the account-type-refactoring branch from db2d4fb to 453bf47 Compare December 2, 2024 15:15
Rotheem and others added 7 commits December 3, 2024 22:49
@Rotheem @armanddidierjean @VisionHabitatLoiret
Transform AccountType from groups to user's attribute (#612)
8196515 
### Description

- AccountType is now a unique attribute of each user, bringing more
consistency to it
- Everything that could be filtered by groups can now be filtered by
account type too (endpoints, visibility, auth clients)
- Added module awareness to visibility
- Removed external filter on user creation

### Checklist

- [ ] Created tests which fail without the change (if possible)
- [ ] All tests passing
- [ ] Extended the documentation, if necessary

---------

Co-authored-by: Armand Didierjean <[email protected]>
Co-authored-by: VisionHabitatLoiret <[email protected]>
@Rotheem
Fix: Account type refactoring CoreData migration (#627)
66e7531 
### Description

Please explain the changes you made here.

### Checklist

- [ ] Created tests which fail without the change (if possible)
- [ ] All tests passing
- [ ] Extended the documentation, if necessary
@dependabot @Daihecyy
Bump python-multipart from 0.0.9 to 0.0.18 (#626)
c652755 
Bumps [python-multipart](https://github.com/Kludex/python-multipart)
from 0.0.9 to 0.0.18.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/Kludex/python-multipart/releases">python-multipart's
releases</a>.</em></p>
<blockquote>
<h2>Version 0.0.18</h2>
<h2>What's Changed</h2>
<ul>
<li>Hard break if found data after last boundary on
<code>MultipartParser</code> by <a
href="https://github.com/Kludex"><code>@​Kludex</code></a> in <a
href="https://redirect.github.com/Kludex/python-multipart/pull/189">Kludex/python-multipart#189</a></li>
</ul>
<hr />
<p><strong>Full Changelog</strong>: <a
href="https://github.com/Kludex/python-multipart/compare/0.0.17...0.0.18">https://github.com/Kludex/python-multipart/compare/0.0.17...0.0.18</a></p>
<h2>Version 0.0.17</h2>
<h2>What's Changed</h2>
<ul>
<li>Handle PermissionError in fallback code for old import name by <a
href="https://github.com/defnull"><code>@​defnull</code></a> in <a
href="https://redirect.github.com/Kludex/python-multipart/pull/182">Kludex/python-multipart#182</a></li>
</ul>
<hr />
<p><strong>Full Changelog</strong>: <a
href="https://github.com/Kludex/python-multipart/compare/0.0.16...0.0.17">https://github.com/Kludex/python-multipart/compare/0.0.16...0.0.17</a></p>
<h2>Version 0.0.16</h2>
<h2>What's Changed</h2>
<ul>
<li>Add dunder attributes to <code>multipart</code> package by <a
href="https://github.com/Kludex"><code>@​Kludex</code></a> in <a
href="https://redirect.github.com/Kludex/python-multipart/pull/177">Kludex/python-multipart#177</a></li>
</ul>
<hr />
<p><strong>Full Changelog</strong>: <a
href="https://github.com/Kludex/python-multipart/compare/0.0.15...0.0.16">https://github.com/Kludex/python-multipart/compare/0.0.15...0.0.16</a></p>
<h2>Version 0.0.15</h2>
<h2>What's Changed</h2>
<ul>
<li>Replace <code>FutureWarning</code> to
<code>PendingDeprecationWarning</code> <a
href="https://redirect.github.com/Kludex/python-multipart/pull/174">#174</a>.</li>
<li>Add missing files to SDist <a
href="https://redirect.github.com/Kludex/python-multipart/pull/171">#171</a>.</li>
</ul>
<hr />
<p><strong>Full Changelog</strong>: <a
href="https://github.com/Kludex/python-multipart/compare/0.0.14...0.0.15">https://github.com/Kludex/python-multipart/compare/0.0.14...0.0.15</a></p>
<h2>Version 0.0.14</h2>
<h2>What's Changed</h2>
<ul>
<li>fix: use alternate scheme for importing multipart by <a
href="https://github.com/henryiii"><code>@​henryiii</code></a> in <a
href="https://redirect.github.com/Kludex/python-multipart/pull/168">Kludex/python-multipart#168</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/Kludex/python-multipart/compare/0.0.13...0.0.14">https://github.com/Kludex/python-multipart/compare/0.0.13...0.0.14</a></p>
<h2>Version 0.0.13</h2>
<h2>What's Changed</h2>
<ul>
<li>Rename import to python_multipart by <a
href="https://github.com/henryiii"><code>@​henryiii</code></a> in <a
href="https://redirect.github.com/Kludex/python-multipart/pull/166">Kludex/python-multipart#166</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/henryiii"><code>@​henryiii</code></a>
made their first contribution in <a
href="https://redirect.github.com/Kludex/python-multipart/pull/166">Kludex/python-multipart#166</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/Kludex/python-multipart/compare/0.0.12...0.0.13">https://github.com/Kludex/python-multipart/compare/0.0.12...0.0.13</a></p>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/Kludex/python-multipart/blob/master/CHANGELOG.md">python-multipart's
changelog</a>.</em></p>
<blockquote>
<h2>0.0.18 (2024-11-28)</h2>
<ul>
<li>Hard break if found data after last boundary on
<code>MultipartParser</code> <a
href="https://redirect.github.com/Kludex/python-multipart/pull/189">#189</a>.</li>
</ul>
<h2>0.0.17 (2024-10-31)</h2>
<ul>
<li>Handle PermissionError in fallback code for old import name <a
href="https://redirect.github.com/Kludex/python-multipart/pull/182">#182</a>.</li>
</ul>
<h2>0.0.16 (2024-10-27)</h2>
<ul>
<li>Add dunder attributes to <code>multipart</code> package <a
href="https://redirect.github.com/Kludex/python-multipart/pull/177">#177</a>.</li>
</ul>
<h2>0.0.15 (2024-10-27)</h2>
<ul>
<li>Replace <code>FutureWarning</code> to
<code>PendingDeprecationWarning</code> <a
href="https://redirect.github.com/Kludex/python-multipart/pull/174">#174</a>.</li>
<li>Add missing files to SDist <a
href="https://redirect.github.com/Kludex/python-multipart/pull/171">#171</a>.</li>
</ul>
<h2>0.0.14 (2024-10-24)</h2>
<ul>
<li>Fix import scheme for <code>multipart</code> module (<a
href="https://redirect.github.com/Kludex/python-multipart/pull/168">#168</a>).</li>
</ul>
<h2>0.0.13 (2024-10-20)</h2>
<ul>
<li>Rename import to <code>python_multipart</code> <a
href="https://redirect.github.com/Kludex/python-multipart/pull/166">#166</a>.</li>
</ul>
<h2>0.0.12 (2024-09-29)</h2>
<ul>
<li>Improve error message when boundary character does not match <a
href="https://redirect.github.com/Kludex/python-multipart/pull/124">#124</a>.</li>
<li>Add mypy strict typing <a
href="https://redirect.github.com/Kludex/python-multipart/pull/140">#140</a>.</li>
<li>Enforce 100% coverage <a
href="https://redirect.github.com/Kludex/python-multipart/pull/159">#159</a>.</li>
</ul>
<h2>0.0.11 (2024-09-28)</h2>
<ul>
<li>Improve performance, especially in data with many CR-LF <a
href="https://redirect.github.com/Kludex/python-multipart/pull/137">#137</a>.</li>
<li>Handle invalid CRLF in header name <a
href="https://redirect.github.com/Kludex/python-multipart/pull/141">#141</a>.</li>
</ul>
<h2>0.0.10 (2024-09-21)</h2>
<ul>
<li>Support <code>on_header_begin</code> <a
href="https://redirect.github.com/Kludex/python-multipart/pull/103">#103</a>.</li>
<li>Improve type hints on <code>FormParser</code> <a
href="https://redirect.github.com/Kludex/python-multipart/pull/104">#104</a>.</li>
<li>Fix <code>OnFileCallback</code> type <a
href="https://redirect.github.com/Kludex/python-multipart/pull/106">#106</a>.</li>
<li>Improve type hints <a
href="https://redirect.github.com/Kludex/python-multipart/pull/110">#110</a>.</li>
<li>Improve type hints on <code>File</code> <a
href="https://redirect.github.com/Kludex/python-multipart/pull/111">#111</a>.</li>
<li>Add type hint to helper functions <a
href="https://redirect.github.com/Kludex/python-multipart/pull/112">#112</a>.</li>
<li>Minor fix for Field.<strong>repr</strong> <a
href="https://redirect.github.com/Kludex/python-multipart/pull/114">#114</a>.</li>
<li>Fix use of chunk_size parameter <a
href="https://redirect.github.com/Kludex/python-multipart/pull/136">#136</a>.</li>
<li>Allow digits and valid token chars in headers <a
href="https://redirect.github.com/Kludex/python-multipart/pull/134">#134</a>.</li>
<li>Fix headers being carried between parts <a
href="https://redirect.github.com/Kludex/python-multipart/pull/135">#135</a>.</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/Kludex/python-multipart/commit/5b1aed83adadbff1677779cd0df53723cd80a0d6"><code>5b1aed8</code></a>
Version 0.0.18 (<a
href="https://redirect.github.com/Kludex/python-multipart/issues/191">#191</a>)</li>
<li><a
href="https://github.com/Kludex/python-multipart/commit/9205a0ec8c646b9f705430a6bfb52bd957b76c19"><code>9205a0e</code></a>
Hard break if found data after last boundary on
<code>MultipartParser</code> (<a
href="https://redirect.github.com/Kludex/python-multipart/issues/189">#189</a>)</li>
<li><a
href="https://github.com/Kludex/python-multipart/commit/170e6043ffeb8f9fb6ad622729f3eda3f45b98cb"><code>170e604</code></a>
Update ruff &amp; mypy (<a
href="https://redirect.github.com/Kludex/python-multipart/issues/188">#188</a>)</li>
<li><a
href="https://github.com/Kludex/python-multipart/commit/e53b541356981b2353914ef5dbf6a1b0605f31c5"><code>e53b541</code></a>
Create SECURITY.md (<a
href="https://redirect.github.com/Kludex/python-multipart/issues/187">#187</a>)</li>
<li><a
href="https://github.com/Kludex/python-multipart/commit/02d1ec148b40470b8bbb25dd833c1e1aace51a8b"><code>02d1ec1</code></a>
fuzz: fix boundary error (<a
href="https://redirect.github.com/Kludex/python-multipart/issues/179">#179</a>)</li>
<li><a
href="https://github.com/Kludex/python-multipart/commit/616b81e72fe67ce67e332c446513ef89b9d816dc"><code>616b81e</code></a>
Version 0.0.17 (<a
href="https://redirect.github.com/Kludex/python-multipart/issues/183">#183</a>)</li>
<li><a
href="https://github.com/Kludex/python-multipart/commit/ca52662eda368bd61fbb9508bfaffb0fc4af6028"><code>ca52662</code></a>
Handle PermissionError in fallback code for old import name (<a
href="https://redirect.github.com/Kludex/python-multipart/issues/182">#182</a>)</li>
<li><a
href="https://github.com/Kludex/python-multipart/commit/876406774d9b98c7b3afa24c3a0c901215f87029"><code>8764067</code></a>
Version 0.0.16 (<a
href="https://redirect.github.com/Kludex/python-multipart/issues/177">#177</a>)</li>
<li><a
href="https://github.com/Kludex/python-multipart/commit/ce85154ff138227654e19d5a47eea6b316bba427"><code>ce85154</code></a>
Version 0.0.15 (<a
href="https://redirect.github.com/Kludex/python-multipart/issues/175">#175</a>)</li>
<li><a
href="https://github.com/Kludex/python-multipart/commit/73fb55d1f8fec576759fcc3c11cc0807d246af00"><code>73fb55d</code></a>
ci: check-sdist (<a
href="https://redirect.github.com/Kludex/python-multipart/issues/172">#172</a>)</li>
<li>Additional commits viewable in <a
href="https://github.com/Kludex/python-multipart/compare/0.0.9...0.0.18">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=python-multipart&package-manager=pip&previous-version=0.0.9&new-version=0.0.18)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
You can disable automated security fix PRs for this repo from the
[Security Alerts
page](https://github.com/aeecleclair/Hyperion/network/alerts).

</details>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Daihecyy <[email protected]>
Co-authored-by: Paul Saubusse <[email protected]>
@Rotheem
Feat: bump titan minimal (#632)
bf564fc 
### Description

Please explain the changes you made here.

### Checklist

- [ ] Created tests which fail without the change (if possible)
- [ ] All tests passing
- [ ] Extended the documentation, if necessary
@Rotheem
Change requirements (#637)
f0f612c 
### Description

Please explain the changes you made here.

### Checklist

- [ ] Created tests which fail without the change (if possible)
- [ ] All tests passing
- [ ] Extended the documentation, if necessary
@Rotheem
Update fastapi requirement (#640)
948ce9f 
### Description

Please explain the changes you made here.

### Checklist

- [ ] Created tests which fail without the change (if possible)
- [ ] All tests passing
- [ ] Extended the documentation, if necessary
@KirillBorodinskiy
Fixed: changed file format of a default cover from .jpg to .jpeg (#636)
5f2433a 
### Description

This should resolve issue #635

### Checklist

- [ ] Created tests which fail without the change (if possible)
- [x] All tests passing
- [ ] Extended the documentation, if necessary
Rotheem added 28 commits December 22, 2024 19:19
@Rotheem
Fix: remove unused migration
24aece3
@Rotheem
Fix: reorder migrations
4f872c0
@Rotheem
Feat: add test to exclude group in user dependency
dad7263
@Rotheem
Fix: remove useless override
ea7868d
@Rotheem
Fix: linting
e33d870
@Rotheem
Feat: refactoring providers and auth
fcbc87b
@Rotheem
Feat: add schools
c00bb80
@Rotheem
Fix: rebase
c305a8f
@Rotheem
Fix: reorder migrations
750a1ef
@Rotheem
Fix: migration
4145e74
@Rotheem
Fix: migration
32eae7e
@Rotheem
Fix: migration
8d2dd31
@Rotheem
Fix: migration
72f46cf
@Rotheem
Fix: migration
4fc8e05
@Rotheem
Fix: migration
1c22977
@Rotheem
Fix: student regex
9df1c57
@Rotheem
Fix: tests
193a8a2
@Rotheem
Fix: remove school from core_user init
a5e1505
@Rotheem
Fix: initialise schools on launch
2843d27
@Rotheem
Fix: migration and user declaration
ebfebbc
@Rotheem
Fix: add router
fe3d315
@Rotheem
Feat: remove school_id from user creation
42e7368
@Rotheem
Feat: tests
5283619
@Rotheem
Feat: add users to school on school creation
ee23801
@Rotheem
Fix: add comment
3a71278
@Rotheem
Fix: correct rebase
e5ca8d2
@Rotheem
Fix: change tests name
b8c0f4d
@Rotheem
Fix: correct rebase
8e31881
@Rotheem Rotheem closed this Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rotheem @KirillBorodinskiy